From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B336C433E2 for ; Fri, 26 Jun 2020 12:30:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C2BF207E8 for ; Fri, 26 Jun 2020 12:30:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C2BF207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E5566B0006; Fri, 26 Jun 2020 08:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46D916B0007; Fri, 26 Jun 2020 08:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3368A6B0008; Fri, 26 Jun 2020 08:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 1C2246B0006 for ; Fri, 26 Jun 2020 08:30:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D5ACD181ABE84 for ; Fri, 26 Jun 2020 12:30:57 +0000 (UTC) X-FDA: 76971297354.07.touch95_4f0bf9726e55 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id ADFED1803F9AD for ; Fri, 26 Jun 2020 12:30:57 +0000 (UTC) X-HE-Tag: touch95_4f0bf9726e55 X-Filterd-Recvd-Size: 3662 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 26 Jun 2020 12:30:57 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id u26so8804615wmn.1 for ; Fri, 26 Jun 2020 05:30:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PdIzhIqqq81bVh2J96q1NfRZRm+GfdGuhuzCVfjHjC4=; b=pX2UsURshWcVX6EUCfkCEfYXs+PddzV7PXnnDmb6i8Pd/99r9b/j5gtYamDZZklub0 e3L6SFxjNUxAq8ocbKawnUtIAQWdq+P8iyC9dNJ3BVvec0n2TojX0BeltMYojbGjYxUw s/l8Ob/NCvsRXle8oSYhn7bJL7MR/KwtO/TiL5c70pq0OTe9Q4n1vsjYtKcnrD9YYlG8 TMEmBcsBBOwsJkWXKYawL7iK2K/2cWkQa1T6ITv/dxAGXYemH+JUxFwnghSH90VbfUVN 7STSClrUwvTCW/sdpkEHqEine9WmfBLaAJW6TYIM2DfcKyZ03chXx0MWFtZ5zf6+JHS9 O8dw== X-Gm-Message-State: AOAM532rcbIavgLd95wQcCx1Ko6xTG23sm8cOtWSDSUO6ybycnBeJxII 2K04SQo3Z2l09HmUwXGjGGM= X-Google-Smtp-Source: ABdhPJxGTInZjFXYhdmJTDvdDFPDLIdw452+wup1lh9sxV+r9yrmee1J1LAn9lOgmZ+NQaKYNizMeA== X-Received: by 2002:a05:600c:4109:: with SMTP id j9mr3087616wmi.157.1593174656252; Fri, 26 Jun 2020 05:30:56 -0700 (PDT) Received: from localhost (ip-37-188-168-3.eurotel.cz. [37.188.168.3]) by smtp.gmail.com with ESMTPSA id u186sm17745558wmu.10.2020.06.26.05.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 05:30:55 -0700 (PDT) Date: Fri, 26 Jun 2020 14:30:54 +0200 From: Michal Hocko To: Ben Widawsky Cc: linux-mm , Andrew Morton , Lee Schermerhorn Subject: Re: [PATCH 02/18] mm/mempolicy: Use node_mem_id() instead of node_id() Message-ID: <20200626123054.GY1320@dhcp22.suse.cz> References: <20200619162425.1052382-1-ben.widawsky@intel.com> <20200619162425.1052382-3-ben.widawsky@intel.com> <20200624082559.GE1320@dhcp22.suse.cz> <20200624164837.pd5q6ox3qgwifpay@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624164837.pd5q6ox3qgwifpay@intel.com> X-Rspamd-Queue-Id: ADFED1803F9AD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 24-06-20 09:48:37, Ben Widawsky wrote: > On 20-06-24 10:25:59, Michal Hocko wrote: > > On Fri 19-06-20 09:24:09, Ben Widawsky wrote: > > > Calling out some distinctions first as I understand it, and the > > > reasoning of the patch: > > > numa_node_id() - The node id for the currently running CPU. > > > numa_mem_id() - The node id for the closest memory node. > > > > Correct > > > > > The case where they are not the same is CONFIG_HAVE_MEMORYLESS_NODES. > > > Only ia64 and powerpc support this option, so it is perhaps not a very > > > interesting situation to most. > > > > Other arches can have nodes without any memory as well. Just offline all > > the managed memory via hotplug... (please note that such node still > > might have memory present! Just not useable by the page allocator) > > You must have CONFIG_HAVE_MEMORYLESS_NODES defined. So I believe that this > change is limited to ia64 and powerpc. I don't think there is a way to set it > outside of those arches. I have tried to say that while other arches (like x86) do not have CONFIG_HAVE_MEMORYLESS_NODES defined they still can end up with a memory node without any memory. Just use memory hotplug... -- Michal Hocko SUSE Labs