From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4777C433E0 for ; Fri, 26 Jun 2020 13:35:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BBCA207D8 for ; Fri, 26 Jun 2020 13:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="gIbnxLuj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BBCA207D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C218A6B0003; Fri, 26 Jun 2020 09:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD5136B0005; Fri, 26 Jun 2020 09:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE64A6B0007; Fri, 26 Jun 2020 09:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 940E16B0003 for ; Fri, 26 Jun 2020 09:35:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1FD26181ABE86 for ; Fri, 26 Jun 2020 13:35:33 +0000 (UTC) X-FDA: 76971460146.13.trick17_350e6ce26e55 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id CDCD318140B67 for ; Fri, 26 Jun 2020 13:35:31 +0000 (UTC) X-HE-Tag: trick17_350e6ce26e55 X-Filterd-Recvd-Size: 6518 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 26 Jun 2020 13:35:31 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id k18so8728272qke.4 for ; Fri, 26 Jun 2020 06:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=xn71QFIb8qusqk6JAn4tYu6VJ7+zbg7ZI59cESgAEKE=; b=gIbnxLujnMPTJPjMstwtM2cv7Rg3sVR0z1lIPDXa8D7lyOP07aknCWIcE/IxySeEIU veQNeet69QpvCzaEZE4pQTtSZPKdpX00B0oDOOgBVb+oMii3xGkjsi6QCaj/r8b8Sqdn PZ7C+Qx0WdXJdne4PscOqu6s4HUhVM3XW5SdWohXtrF4/Mrr2PNhkL5uApP5igTlZeqa QNIvHj051iT9uhr6+D01oitcmxXsxMdji7rXRFYD9+mSeR7AlnUSCRsMslcn2LIntanc 2EJnJoGS/4C5kZTqQvMZzc/MranpZiVywjgCML/r7lqyRec6k4ubnmLAeXuHKzZuwK/s 4yYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xn71QFIb8qusqk6JAn4tYu6VJ7+zbg7ZI59cESgAEKE=; b=Im6yRJSLW8KZXG0o5renB6U37LcfAtRwAF6VNnpQzlJ1HnpanymL08lG9bXOVNn4mp e6o8hE1pi0d5JS6sgXVTUSZQdqWIBIgn+80kHwCRvszr1eGtXvZ6efz3PNyqwYDLmUdl KLBQuJ6eQLg2cvUKWmyPzCdH9Qni9hlTDO7hXRQLpvmnAvM9wV41S1f8EUdybNyr8n9a 29JF7L2XZayeFFpeveev6mxKJ/TJgBQBiQmA9Yfgl9Onv4829zkYwgfzObnN7YrQHZzX 0qD4AE8aityqtoCB72+fZXTd5jdOLe125MGwDa+5H+ulJiFGdNvBWlPKRbcLfAfse9eN iu6g== X-Gm-Message-State: AOAM531x4CgdErp85fIOmT7ByU+7VkjrxJEG3Kxd8Ip1Cepx5i5W+iwM hJivl6T2fa0dGLbSRwGx7Gdt9Q== X-Google-Smtp-Source: ABdhPJzrPtm0RKVTxghv+yE8IvD/PfDgFvmqJDyTjnDquuanCkcbhkwlgua0WRtE1UBAddUHUYWpFw== X-Received: by 2002:a37:46ca:: with SMTP id t193mr2727669qka.293.1593178530579; Fri, 26 Jun 2020 06:35:30 -0700 (PDT) Received: from lca.pw (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id v45sm9773254qtv.47.2020.06.26.06.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:35:29 -0700 (PDT) Date: Fri, 26 Jun 2020 09:35:21 -0400 From: Qian Cai To: nao.horiguchi@gmail.com Cc: linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, osalvador@suse.de, tony.luck@intel.com, david@redhat.com, aneesh.kumar@linux.vnet.ibm.com, zeil@yandex-team.ru, naoya.horiguchi@nec.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/15] HWPOISON: soft offline rework Message-ID: <20200626133521.GA3933@lca.pw> References: <20200624150137.7052-1-nao.horiguchi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200624150137.7052-1-nao.horiguchi@gmail.com> X-Rspamd-Queue-Id: CDCD318140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 24, 2020 at 03:01:22PM +0000, nao.horiguchi@gmail.com wrote: > I rebased soft-offline rework patchset [1][2] onto the latest mmotm. T= he > rebasing required some non-trivial changes to adjust, but mainly that w= as > straightforward. I confirmed that the reported problem doesn't reprodu= ce on > compaction after soft offline. For more precise description of the pro= blem > and the motivation of this patchset, please see [2]. >=20 > I think that the following two patches in v2 are better to be done with > separate work of hard-offline rework, so it's not included in this seri= es. >=20 > - mm,hwpoison: Take pages off the buddy when hard-offlining > - mm/hwpoison-inject: Rip off duplicated checks >=20 > These two are not directly related to the reported problem, so they see= ms > not urgent. And the first one breaks num_poisoned_pages counting in so= me > testcases, and The second patch needs more consideration about commente= d point. >=20 > Any comment/suggestion/help would be appreciated. Next-20200626 failed to compile due to this series. Reverting the whole thing [1] will fix the issue below right away, mm/memory-failure.c: In function =E2=80=98__soft_offline_page=E2=80=99: mm/memory-failure.c:1827:3: error: implicit declaration of function =E2=80= =98page_handle_poison=E2=80=99; did you mean =E2=80=98page_init_poison=E2= =80=99? [-Werror=3Dimplicit-function-declaration] page_handle_poison(page, false, true); ^~~~~~~~~~~~~~~~~~ page_init_poison .config used, https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config https://raw.githubusercontent.com/cailca/linux-mm/master/arm64.config [1] git revert --no-edit f296ba1d3a07..0bd1762119e9 >=20 > [1] v1: https://lore.kernel.org/linux-mm/1541746035-13408-1-git-send-em= ail-n-horiguchi@ah.jp.nec.com/ > [2] v2: https://lore.kernel.org/linux-mm/20191017142123.24245-1-osalvad= or@suse.de/ >=20 > Thanks, > Naoya Horiguchi > --- > Summary: >=20 > Naoya Horiguchi (7): > mm,hwpoison: cleanup unused PageHuge() check > mm, hwpoison: remove recalculating hpage > mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED > mm,hwpoison-inject: don't pin for hwpoison_filter > mm,hwpoison: remove MF_COUNT_INCREASED > mm,hwpoison: remove flag argument from soft offline functions > mm,hwpoison: introduce MF_MSG_UNSPLIT_THP >=20 > Oscar Salvador (8): > mm,madvise: Refactor madvise_inject_error > mm,hwpoison: Un-export get_hwpoison_page and make it static > mm,hwpoison: Kill put_hwpoison_page > mm,hwpoison: Unify THP handling for hard and soft offline > mm,hwpoison: Rework soft offline for free pages > mm,hwpoison: Rework soft offline for in-use pages > mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_p= age > mm,hwpoison: Return 0 if the page is already poisoned in soft-off= line >=20 > drivers/base/memory.c | 2 +- > include/linux/mm.h | 12 +- > include/linux/page-flags.h | 6 +- > include/ras/ras_event.h | 3 + > mm/hwpoison-inject.c | 18 +-- > mm/madvise.c | 39 +++--- > mm/memory-failure.c | 331 ++++++++++++++++++++-----------------= -------- > mm/migrate.c | 11 +- > mm/page_alloc.c | 63 +++++++-- > 9 files changed, 233 insertions(+), 252 deletions(-) >=20