From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EB2C433E0 for ; Fri, 3 Jul 2020 22:15:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB3E520885 for ; Fri, 3 Jul 2020 22:15:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bb54mbmB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB3E520885 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 749B08D009C; Fri, 3 Jul 2020 18:15:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720FB8D0010; Fri, 3 Jul 2020 18:15:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65DB28D009C; Fri, 3 Jul 2020 18:15:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 520FD8D0010 for ; Fri, 3 Jul 2020 18:15:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 105C9181AC9CB for ; Fri, 3 Jul 2020 22:15:23 +0000 (UTC) X-FDA: 76998171726.26.coil61_5b0d7fe26e95 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id E2AE81804B676 for ; Fri, 3 Jul 2020 22:15:22 +0000 (UTC) X-HE-Tag: coil61_5b0d7fe26e95 X-Filterd-Recvd-Size: 3269 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 22:15:22 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9150620884; Fri, 3 Jul 2020 22:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593814521; bh=rnO4VKsmcewpLk3+dbcyHtm1Vnlph+wpJcVUz1wtQpg=; h=Date:From:To:Subject:In-Reply-To:From; b=bb54mbmBDtJEgQDKwaxjRsW2BaYkk8ygBheDlctNA1K8I0+M+4BgWjMy64F2gxBYH ZTNF5JKqIu6mOD4WxKBTyABiT2rfBuZJstxPFMdv1fWGde9L7fO3yG/u8rD+AAdtb1 g6lIipCyBNmCmbmkWa/Hb+KyQv1tEuiD+4ara/HQ= Date: Fri, 03 Jul 2020 15:15:21 -0700 From: Andrew Morton To: akpm@linux-foundation.org, dhowells@redhat.com, keescook@chromium.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, mszeredi@redhat.com, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: [patch 2/5] samples/vfs: avoid warning in statx override Message-ID: <20200703221521.pD8I0o7qW%akpm@linux-foundation.org> In-Reply-To: <20200703151445.b6a0cfee402c7c5c4651f1b1@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: E2AE81804B676 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kees Cook Subject: samples/vfs: avoid warning in statx override Something changed recently to uncover this warning: samples/vfs/test-statx.c:24:15: warning: `struct foo' declared inside parameter list will not be visible outside of this definition or declaration 24 | #define statx foo | ^~~ Which is due the use of "struct statx" (here, "struct foo") in a function prototype argument list before it has been defined: int # 56 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" foo # 56 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" 3 4 (int __dirfd, const char *__restrict __path, int __flags, unsigned int __mask, struct # 57 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" foo # 57 "/usr/include/x86_64-linux-gnu/bits/statx-generic.h" 3 4 *__restrict __buf) __attribute__ ((__nothrow__ , __leaf__)) __attribute__ ((__nonnull__ (2, 5))); Add explicit struct before #include to avoid warning. Link: http://lkml.kernel.org/r/202006282213.C516EA6@keescook Fixes: f1b5618e013a ("vfs: Add a sample program for the new mount API") Signed-off-by: Kees Cook Cc: Miklos Szeredi Cc: Al Viro Cc: David Howells Signed-off-by: Andrew Morton --- samples/vfs/test-statx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/samples/vfs/test-statx.c~samples-vfs-avoid-warning-in-statx-override +++ a/samples/vfs/test-statx.c @@ -23,6 +23,8 @@ #include #define statx foo #define statx_timestamp foo_timestamp +struct statx; +struct statx_timestamp; #include #undef statx #undef statx_timestamp _