From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
yang.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org,
thomas_os@shipmail.org, thellstrom@vmware.com,
anshuman.khandual@arm.com, sean.j.christopherson@intel.com,
aneesh.kumar@linux.ibm.com, peterx@redhat.com, walken@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
digetx@gmail.com
Subject: Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
Date: Mon, 6 Jul 2020 13:08:19 +0300 [thread overview]
Message-ID: <20200706100819.flwgozlstn3zl66u@box> (raw)
In-Reply-To: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com>
On Fri, Jun 26, 2020 at 09:52:12PM +0800, Wei Yang wrote:
> move_page_tables() tries to move page table by PMD or PTE.
>
> The root reason is if it tries to move PMD, both old and new range should be
> PMD aligned. But current code calculate old range and new range separately.
> This leads to some redundant check and calculation.
>
> This cleanup tries to consolidate the range check in one place to reduce some
> extra range handling.
The patchet looks good to me. I have few nits, but nothing substantial.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-07-06 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 13:52 [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-06-26 13:52 ` [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Wei Yang
2020-07-06 10:06 ` Kirill A. Shutemov
2020-06-26 13:52 ` [RESEND Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-06-26 13:52 ` [RESEND Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-07-06 10:07 ` Kirill A. Shutemov
2020-07-07 1:38 ` Wei Yang
2020-07-07 10:47 ` Kirill A. Shutemov
2020-07-07 12:53 ` Wei Yang
2020-06-26 13:52 ` [RESEND Patch v2 4/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-07-06 10:08 ` Kirill A. Shutemov [this message]
2020-07-06 22:06 ` [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-07-06 23:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706100819.flwgozlstn3zl66u@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=digetx@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=sean.j.christopherson@intel.com \
--cc=thellstrom@vmware.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).