From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E33C433E1 for ; Thu, 9 Jul 2020 05:32:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51E19206A1 for ; Thu, 9 Jul 2020 05:32:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51E19206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EDB9B6B000A; Thu, 9 Jul 2020 01:32:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8BAE6B000C; Thu, 9 Jul 2020 01:32:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA1816B000D; Thu, 9 Jul 2020 01:32:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id C486D6B000A for ; Thu, 9 Jul 2020 01:32:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3E27982499B9 for ; Thu, 9 Jul 2020 05:32:38 +0000 (UTC) X-FDA: 77017417596.05.farm36_2513dd426ec3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 10CAE18022293 for ; Thu, 9 Jul 2020 05:32:38 +0000 (UTC) X-HE-Tag: farm36_2513dd426ec3 X-Filterd-Recvd-Size: 2319 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 05:32:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2292B68B05; Thu, 9 Jul 2020 07:32:34 +0200 (CEST) Date: Thu, 9 Jul 2020 07:32:33 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: remove dead bdi congestion leftovers Message-ID: <20200709053233.GA3243@lst.de> References: <20200701090622.3354860-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 10CAE18022293 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: > On 7/1/20 3:06 AM, Christoph Hellwig wrote: > > Hi Jens, > >=20 > > we have a lot of bdi congestion related code that is left around with= out > > any use. This series removes it in preparation of sorting out the bd= i > > lifetime rules properly. >=20 > Please run series like this through a full compilation, for both this o= ne > and the previous series I had to fix up issues like this: >=20 > drivers/md/bcache/request.c: In function =E2=80=98bch_cached_dev_reques= t_init=E2=80=99: > drivers/md/bcache/request.c:1233:18: warning: unused variable =E2=80=98= g=E2=80=99 [-Wunused-variable] > 1233 | struct gendisk *g =3D dc->disk.disk; > | ^ > drivers/md/bcache/request.c: In function =E2=80=98bch_flash_dev_request= _init=E2=80=99: > drivers/md/bcache/request.c:1320:18: warning: unused variable =E2=80=98= g=E2=80=99 [-Wunused-variable] > 1320 | struct gendisk *g =3D d->disk; > | ^ >=20 > Did the same here, applied it. And just like the previous one I did, and the compiler did not complain. There must be something about certain gcc versions not warning about variables that are initialized but not otherwise used.