From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEB4C433E1 for ; Thu, 9 Jul 2020 16:57:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA74F207D0 for ; Thu, 9 Jul 2020 16:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="ohj96eQb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA74F207D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74C046B0005; Thu, 9 Jul 2020 12:57:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FDCE6B0006; Thu, 9 Jul 2020 12:57:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C31C6B0007; Thu, 9 Jul 2020 12:57:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 45E2E6B0005 for ; Thu, 9 Jul 2020 12:57:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ECCD9824805A for ; Thu, 9 Jul 2020 16:57:29 +0000 (UTC) X-FDA: 77019143418.24.scene66_190d6ba26ec7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id BBA571A4A5 for ; Thu, 9 Jul 2020 16:57:29 +0000 (UTC) X-HE-Tag: scene66_190d6ba26ec7 X-Filterd-Recvd-Size: 4304 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 16:57:29 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 Jul 2020 09:57:15 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 09 Jul 2020 09:57:27 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 09 Jul 2020 09:57:27 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Jul 2020 16:57:19 +0000 Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 9 Jul 2020 16:57:19 +0000 Received: from rcampbell-dev.nvidia.com (Not Verified[10.110.48.66]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Thu, 09 Jul 2020 09:57:19 -0700 From: Ralph Campbell To: , , , CC: Jerome Glisse , John Hubbard , Christoph Hellwig , Jason Gunthorpe , "Bharata B Rao" , Shuah Khan , Andrew Morton , Ralph Campbell Subject: [PATCH 1/2] mm/migrate: optimize migrate_vma_setup() for holes Date: Thu, 9 Jul 2020 09:57:10 -0700 Message-ID: <20200709165711.26584-2-rcampbell@nvidia.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200709165711.26584-1-rcampbell@nvidia.com> References: <20200709165711.26584-1-rcampbell@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594313835; bh=B2D/nS1wOmFM1BnqXCP74e2MZLq0Kn5AbDcOovgyNoI=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=ohj96eQbydmV4kRF027+IYlNfuLSjZlOYmKTmjsLUdErYCgeG6G8GXVP1Ch1NvqKb VfQRNMApdYINbV1gCcw6ZXWDH5J2+QkMq6sNFAyjDF9vBnhk+O5aJGcOgeh+fNKaMx T3GXHedfsKe/5bYAi55X+WOqB8N7JNB9k4xcuKmYp1JclNurGSFI3Mq0uhgk5+L1qW MK4Mn98Zi+NIYIjqp0rG4VeUe2XMUUWdV8rzL12AzXnvYVVOl5t2Ymre5SbnJvIsoI Wa7HzIflxlyLka8WbWknLVDVyxq2jC4gMKobdNPT04IKAl8gefMk1ccDGJ+RKCECZG h5HrfNG2JVhKg== X-Rspamd-Queue-Id: BBA571A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When migrating system memory to device private memory, if the source address range is a valid VMA range and there is no memory or a zero page, the source PFN array is marked as valid but with no PFN. This lets the device driver allocate private memory and clear it, then insert the new device private struct page into the CPU's page tables when migrate_vma_pages() is called. migrate_vma_pages() only inserts the new page if the VMA is an anonymous range. There is no point in telling the device driver to allocate device private memory and then not migrate the page. Instead, mark the source PFN array entries as not migrating to avoid this overhead. Signed-off-by: Ralph Campbell --- mm/migrate.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index b0125c082549..8aa434691577 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2204,9 +2204,13 @@ static int migrate_vma_collect_hole(unsigned long st= art, { struct migrate_vma *migrate =3D walk->private; unsigned long addr; + unsigned long flags; + + /* Only allow populating anonymous memory. */ + flags =3D vma_is_anonymous(walk->vma) ? MIGRATE_PFN_MIGRATE : 0; =20 for (addr =3D start; addr < end; addr +=3D PAGE_SIZE) { - migrate->src[migrate->npages] =3D MIGRATE_PFN_MIGRATE; + migrate->src[migrate->npages] =3D flags; migrate->dst[migrate->npages] =3D 0; migrate->npages++; migrate->cpages++; --=20 2.20.1