From: Mike Rapoport <rppt@linux.ibm.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
William Kucharski <william.kucharski@oracle.com>
Subject: Re: [PATCH v2 0/6] Improvements for dump_page()
Date: Thu, 9 Jul 2020 23:54:07 +0300 [thread overview]
Message-ID: <20200709205407.GK781326@linux.ibm.com> (raw)
In-Reply-To: <20200709202117.7216-1-willy@infradead.org>
On Thu, Jul 09, 2020 at 09:21:11PM +0100, Matthew Wilcox (Oracle) wrote:
> Thanks to everyone for your feedback on v1. I haven't added any acks
> from v1 because most of the patches have changed substantially from v1.
Aside from my aesthetic preference to have printk continuation line
below the opening '(' rather then full tab indented the patches look
good.
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> Here's a sample dump of a pagecache tail page with all of the patches applied:
>
> page:000000006d1c49ca refcount:6 mapcount:0 mapping:00000000136b8d90 index:0x109 pfn:0x6c645
> head:000000008bd38076 order:2 compound_mapcount:0 compound_pincount:0
> aops:xfs_address_space_operations ino:800042 dentry name:"fd"
> flags: 0x4000000000012014(uptodate|lru|private|head)
> raw: 4000000000000000 ffffd46ac1b19101 ffffffff00000202 dead000000000004
> raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
> head: 4000000000012014 ffffd46ac1b1bbc8 ffffd46ac1b1bc08 ffff91976f659560
> head: 0000000000000108 ffff919773220680 00000006ffffffff 0000000000000000
> page dumped because: testing
>
> Matthew Wilcox (Oracle) (6):
> mm: Handle page->mapping better in dump_page
> mm: Dump compound page information on a second line
> mm: Print head flags in dump_page
> mm: Switch dump_page to get_kernel_nofault
> mm: Print the inode number in dump_page
> mm: Print hashed address of struct page
>
> mm/debug.c | 75 +++++++++++++++++++++++++-----------------------------
> 1 file changed, 35 insertions(+), 40 deletions(-)
>
> --
> 2.27.0
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-07-09 20:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:21 [PATCH v2 0/6] Improvements for dump_page() Matthew Wilcox (Oracle)
2020-07-09 20:21 ` [PATCH v2 1/6] mm: Handle page->mapping better in dump_page Matthew Wilcox (Oracle)
2020-07-11 1:30 ` John Hubbard
2020-07-11 1:32 ` John Hubbard
2020-07-14 11:06 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 2/6] mm: Dump compound page information on a second line Matthew Wilcox (Oracle)
2020-07-11 1:35 ` John Hubbard
2020-07-14 12:03 ` Vlastimil Babka
2020-08-04 15:37 ` Qian Cai
2020-08-04 16:14 ` Matthew Wilcox
2020-08-04 18:39 ` [PATCH] mm, dump_page: do not crash with bad compound_page() John Hubbard
2020-08-04 18:48 ` Matthew Wilcox
2020-08-04 19:17 ` John Hubbard
2020-08-04 19:42 ` Matthew Wilcox
2020-07-09 20:21 ` [PATCH v2 3/6] mm: Print head flags in dump_page Matthew Wilcox (Oracle)
2020-07-11 1:40 ` John Hubbard
2020-07-14 12:06 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 4/6] mm: Switch dump_page to get_kernel_nofault Matthew Wilcox (Oracle)
2020-07-14 12:11 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 5/6] mm: Print the inode number in dump_page Matthew Wilcox (Oracle)
2020-07-11 2:04 ` John Hubbard
2020-07-14 12:18 ` Vlastimil Babka
2020-07-09 20:21 ` [PATCH v2 6/6] mm: Print hashed address of struct page Matthew Wilcox (Oracle)
2020-07-11 1:48 ` John Hubbard
2020-07-09 20:54 ` Mike Rapoport [this message]
2020-07-09 20:54 ` [PATCH v2 0/6] Improvements for dump_page() William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709205407.GK781326@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).