From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00817C433E1 for ; Mon, 13 Jul 2020 12:13:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3B032072D for ; Mon, 13 Jul 2020 12:13:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="rBNMv/m7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3B032072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44F558D0002; Mon, 13 Jul 2020 08:13:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 400098D0001; Mon, 13 Jul 2020 08:13:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C7788D0002; Mon, 13 Jul 2020 08:13:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 16A968D0001 for ; Mon, 13 Jul 2020 08:13:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 80DF721E4 for ; Mon, 13 Jul 2020 12:13:53 +0000 (UTC) X-FDA: 77032943946.01.able12_2d0c8ac26ee8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 3E62460001EF539E for ; Mon, 13 Jul 2020 12:12:48 +0000 (UTC) X-HE-Tag: able12_2d0c8ac26ee8 X-Filterd-Recvd-Size: 5082 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 12:12:47 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id k18so9659874qtm.10 for ; Mon, 13 Jul 2020 05:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RpYSNQC2exuWKUTSRfbzznKwmjgAwfUEWqW8RzotbS4=; b=rBNMv/m7LaTM5arw6QzFTxkwPH7OghzX2+1T4d0DECfS6DFMcAv1644Lu5aG+V9mCd PMKwN8m//5IvkMkE7befYGE5dNlHQGJ1XgOmVUFV5n1VP1FlkC+JoX7DQVbBuwjIflg0 Xiha5OPk6LbG69HWASAzNTROcVKp7AAUVGBPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RpYSNQC2exuWKUTSRfbzznKwmjgAwfUEWqW8RzotbS4=; b=OlOkD2YEC7UoDr9vK6vYBjfXN6VBGlAdjRSKEufr6KS6FIqYi0ehIJUcu8qELCvkT/ GxBwunA8+nD5gwIt1BeFWhRAmlxzPohMSURwSCIl0n1a1wBs0lVonBTlHiQ3/s2zq6Lk 1gin6Rv4+E6rAJCV+CT1S6J2ECvmCDgdniWFH2kI0kxBpZ62bI8rgVJl5hHQavl7H8bS Q+iZfzf6oY0V/2Zv4HkRoCoR2gXJ050P72nnTdXQqqs8r9Joitg2hyCglyoYMAvJ2T4T ljJ1rURafmDQJuX/fnmj0m9jArort9VKNvv2hFqZn6kl0X61tkcXcJ9HypmeW/Qwsm1L 8T/w== X-Gm-Message-State: AOAM530VyKvBJd+G/VW+kZGGMSLg01c+SlkRfTrTpmUcmbIPykaLOwiq TmYieZdeVSU5QxRIVNhWWoGEAA== X-Google-Smtp-Source: ABdhPJwx4Win/yPZB7k/hma4rHDpqXlvpi9H6cFu4C0fIA3YbzEIBjZE/+zuFQEGlEfG1eUL1EaC+w== X-Received: by 2002:ac8:1a12:: with SMTP id v18mr85096949qtj.347.1594642366926; Mon, 13 Jul 2020 05:12:46 -0700 (PDT) Received: from localhost ([2620:15c:6:12:cad3:ffff:feb3:bd59]) by smtp.gmail.com with ESMTPSA id b8sm19823302qtg.45.2020.07.13.05.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 05:12:46 -0700 (PDT) Date: Mon, 13 Jul 2020 08:12:45 -0400 From: Joel Fernandes To: Linus Torvalds Cc: Naresh Kamboju , linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 Message-ID: <20200713121245.GA3926869@google.com> References: <20200712215041.GA3644504@google.com> <20200713025354.GB3644504@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3E62460001EF539E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 12, 2020 at 08:51:26PM -0700, Linus Torvalds wrote: > > > Maybe saying "doing the pmd copies for the initial stack isn't > > > important, so let's just note this as a special case and get rid of > > > the WARN_ON()" might be an alternative solution. > > > > Personally, I feel it is better to keep the warning just so in the future we > > can detect any bugs. > > I don't disagree, the warning didn't happen to find a bug now, but it > did fine a case we might be able to do better. > > So now that I feel we understand the issue, and it's not a horrible > problem, just a (very hard to trigger) warning, I don't think there's > any huge hurry. > > I think think I will - for now - change the WARN_ON() to > WARN_ON_ONCE() (so that it doesn't floow the logs if somebody triggers > this odd special case this malisiously), and add a note about how > this happens to the code for posterito. > > And if/when you figure out a better way to fix it, we can update the note. > > Ok? Yes, that sounds great to me. thanks, - Joel