From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F5FC433E2 for ; Mon, 13 Jul 2020 12:23:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C11C7207F9 for ; Mon, 13 Jul 2020 12:23:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="oxMYpFiX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11C7207F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 537448D0003; Mon, 13 Jul 2020 08:23:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50E0D8D0001; Mon, 13 Jul 2020 08:23:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FD7F8D0003; Mon, 13 Jul 2020 08:23:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 27B398D0001 for ; Mon, 13 Jul 2020 08:23:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D86302DFD for ; Mon, 13 Jul 2020 12:23:02 +0000 (UTC) X-FDA: 77032967004.05.trail95_4b11ed626ee8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id AC0CC18033D32 for ; Mon, 13 Jul 2020 12:23:02 +0000 (UTC) X-HE-Tag: trail95_4b11ed626ee8 X-Filterd-Recvd-Size: 4613 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 12:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1594642983; x=1626178983; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=TwoQ8bDC2XXe2mOguI1vCZOlb/uARXgWALhiWYIJob0=; b=oxMYpFiXp+a6PMcba4654bKBdZd2uOq8blBEdDz6OK2bx5Sl9lkCbiPN P6TnxTpimqkOKdEryqEklHz1dH6MhnatZlS+YwcbpGzPOKPzbZXvBBnFx /YCqrKlYOShY3bSS/nlkJRHcgyB4wUAVUmwYsnwDVeG+hrOr7MuqFQ2n+ g=; IronPort-SDR: +PigRIvLE03mwAyDt7JldlA+KMu5Cs8Tlez+JFwI3u3KzRMYY5FIriCJixMJRrTFgRcJ0OKGGU Mb4S/MyhrDvg== X-IronPort-AV: E=Sophos;i="5.75,347,1589241600"; d="scan'208";a="42967769" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-f273de60.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 13 Jul 2020 12:23:02 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1d-f273de60.us-east-1.amazon.com (Postfix) with ESMTPS id 52AADA237C; Mon, 13 Jul 2020 12:22:50 +0000 (UTC) Received: from EX13D31EUA004.ant.amazon.com (10.43.165.161) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 13 Jul 2020 12:22:50 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.160.65) by EX13D31EUA004.ant.amazon.com (10.43.165.161) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 13 Jul 2020 12:22:33 +0000 From: SeongJae Park To: Mike Rapoport CC: SeongJae Park , , "SeongJae Park" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: Re: [PATCH v18 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules Date: Mon, 13 Jul 2020 14:21:43 +0200 Message-ID: <20200713122143.25493-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200713120842.GA707159@kernel.org> (raw) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.65] X-ClientProxiedBy: EX13D41UWC001.ant.amazon.com (10.43.162.107) To EX13D31EUA004.ant.amazon.com (10.43.165.161) X-Rspamd-Queue-Id: AC0CC18033D32 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Jul 2020 15:08:42 +0300 Mike Rapoport wrote: > Hi, > > On Mon, Jul 13, 2020 at 10:41:31AM +0200, SeongJae Park wrote: > > From: SeongJae Park > > > > This commit exports 'lookup_page_ext()' to GPL modules. It will be used > > by DAMON in following commit for the implementation of the region based > > sampling. > > Maybe I'm missing something, but why is DAMON a module? I made it loadable just for easier adoption from downstream kernels. I could drop the module build support if asked. Thanks, SeongJae Park > > > Signed-off-by: SeongJae Park > > Reviewed-by: Leonard Foerster > > Reviewed-by: Varad Gautam > > --- > > mm/page_ext.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/page_ext.c b/mm/page_ext.c > > index a3616f7a0e9e..9d802d01fcb5 100644 > > --- a/mm/page_ext.c > > +++ b/mm/page_ext.c > > @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page *page) > > MAX_ORDER_NR_PAGES); > > return get_entry(base, index); > > } > > +EXPORT_SYMBOL_GPL(lookup_page_ext); > > > > static int __init alloc_node_page_ext(int nid) > > { > > -- > > 2.17.1 > > > > -- > Sincerely yours, > Mike.