From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5EAC433E3 for ; Mon, 20 Jul 2020 12:10:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38FD12176B for ; Mon, 20 Jul 2020 12:10:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38FD12176B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6564B6B0003; Mon, 20 Jul 2020 08:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605FE6B0005; Mon, 20 Jul 2020 08:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51C0C6B0006; Mon, 20 Jul 2020 08:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 3C9576B0003 for ; Mon, 20 Jul 2020 08:10:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DBC1A182354A4 for ; Mon, 20 Jul 2020 12:10:17 +0000 (UTC) X-FDA: 77058336474.22.spade43_2e09b5426f24 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id CF729182CF689 for ; Mon, 20 Jul 2020 12:07:39 +0000 (UTC) X-HE-Tag: spade43_2e09b5426f24 X-Filterd-Recvd-Size: 1933 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 12:07:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 18CA168BFE; Mon, 20 Jul 2020 14:07:35 +0200 (CEST) Date: Mon, 20 Jul 2020 14:07:34 +0200 From: Christoph Hellwig To: Richard Weinberger Cc: Christoph Hellwig , Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , linux-mtd@lists.infradead.org, device-mapper development , linux-block@vger.kernel.org, LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , linux-mm@kvack.org, cgroups mailinglist Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init Message-ID: <20200720120734.GA29061@lst.de> References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: CF729182CF689 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 20, 2020 at 01:58:22PM +0200, Richard Weinberger wrote: > Hello Chrstoph, > > On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > > > Set up a readahead size by default. This changes behavior for mtd, > > ubifs, and vboxsf to actually enabled readahead, the lack of which > > very much looks like an oversight. > > UBIFS doesn't enable readahead on purpose, please see: > http://www.linux-mtd.infradead.org/doc/ubifs.html#L_readahead What about jffs2 and blk2mtd raw block devices?