From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6543CC433E1 for ; Wed, 22 Jul 2020 07:07:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B41120709 for ; Wed, 22 Jul 2020 07:07:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B41120709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A597B6B0003; Wed, 22 Jul 2020 03:07:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E24A6B0005; Wed, 22 Jul 2020 03:07:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A8AE6B0006; Wed, 22 Jul 2020 03:07:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 726F36B0003 for ; Wed, 22 Jul 2020 03:07:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0DAED10068AE4 for ; Wed, 22 Jul 2020 07:07:08 +0000 (UTC) X-FDA: 77064830136.04.eye18_2017d9426f34 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id DD00980273F2 for ; Wed, 22 Jul 2020 07:07:07 +0000 (UTC) X-HE-Tag: eye18_2017d9426f34 X-Filterd-Recvd-Size: 2177 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Jul 2020 07:07:07 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C926B6736F; Wed, 22 Jul 2020 09:07:03 +0200 (CEST) Date: Wed, 22 Jul 2020 09:07:03 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , "linux-mtd@lists.infradead.org" , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "drbd-dev@lists.linbit.com" , "linux-raid@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "cgroups@vger.kernel.org" Subject: Re: [PATCH 02/14] drbd: remove dead code in device_to_statistics Message-ID: <20200722070703.GA25590@lst.de> References: <20200722062552.212200-1-hch@lst.de> <20200722062552.212200-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: DD00980273F2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 22, 2020 at 07:03:21AM +0000, Johannes Thumshirn wrote: > On 22/07/2020 08:28, Christoph Hellwig wrote: > > Ever since the switch to blk-mq, a lower device not use by VM > in-use/used? ~^ Yeah, this should be used. > Also this looks like the last user of 'dev_lower_blocked' so it could > be removed from device_statistics if it's not an ABI (not sure with this > netlink stuff). As far as I can tell this is a netlink user ABI.