From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6798C433E0 for ; Fri, 24 Jul 2020 09:13:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73108206EB for ; Fri, 24 Jul 2020 09:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDzT8+/v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73108206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E7CF06B0022; Fri, 24 Jul 2020 05:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D236B0023; Fri, 24 Jul 2020 05:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1DD18D0008; Fri, 24 Jul 2020 05:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id BB5036B0022 for ; Fri, 24 Jul 2020 05:13:24 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 674D6267F1 for ; Fri, 24 Jul 2020 09:13:24 +0000 (UTC) X-FDA: 77072405928.05.horn61_370a16a26f46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 3DFB018039008 for ; Fri, 24 Jul 2020 09:13:24 +0000 (UTC) X-HE-Tag: horn61_370a16a26f46 X-Filterd-Recvd-Size: 5426 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jul 2020 09:13:23 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id o18so9235929eje.7 for ; Fri, 24 Jul 2020 02:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=13FtjbtfLSbB7lUu2KMXehtRfJlBejW7Rr8iZY5Tpxo=; b=nDzT8+/vlYwD6OAFh3eCjMgEf1dSl503zdnwgMgotSNyUi0fcH8vWETzUUnuxBH01A x0FfzQ8ksNoPjskd8E1OpmMiR/RotwWL28mY6QuxcqxNWhwW22zwu9ye+CrhX76LbdWY XA1jbo4lWMU1AymNlEoag9jqAE09KwZDuY0KeWcYrYgox9EMg4dOmO98XfbS4MI0z38y l3eyjKKueH+OsqQ6vpMSBSiRfAIl+WTDWWxT4rlx4B8xRYUa4dHO4GLuWRZtHPCdiquc Q8vU3AgF9EgXR7awHe0F500NGUHfp6JZOGvxH0rUNqotEod+yhvtezKGw8tR0x3kzJjF rIgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=13FtjbtfLSbB7lUu2KMXehtRfJlBejW7Rr8iZY5Tpxo=; b=kmUMSzV9b4cx+lqwUOZvX1UBgFcljGx04jxDo+THh8mBrHHxrw7LmzIJKjOZFP8oEB u564j+BgHGHr0lkbcs6WzgCKPN3qAME0iIlqqMWlSdVFxaY0Qu71M4jh6mrUX0KE7rTZ 2GGtrEhPMtp4/PgFRQS1uwy48JaacDBmjqbt22s0q44QBe/F2xe+WrEGPLN2r6tXHjAq uD+ZQo9orklo9TXuLDWTNO5VjJw2XfF/0PKI+E/W5w+86jHag5nPXg7zgC7BeLn7LpXA fBUAGu6+V64+uv0KeUxLoO8SNhILGi24bcNNRDbzPi4njQaxM29xAaIuaJsRahigSeJF vPgQ== X-Gm-Message-State: AOAM5319t9wJrYfKEut9loNsPe2xEAWnbmI7esbQS+6oJvJqlLQSaD9f znOYDY6w+in3H6AxNcK208g= X-Google-Smtp-Source: ABdhPJwvMQA7GVtYoy+Xz6ijPiKZoA2xSYef8WE3UDmkEnx3stuv579+IF8wQyCwOkO5U/tjnFfdqA== X-Received: by 2002:a17:906:b0d3:: with SMTP id bk19mr8662181ejb.167.1595582002571; Fri, 24 Jul 2020 02:13:22 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id q25sm319164edb.58.2020.07.24.02.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 02:13:21 -0700 (PDT) Date: Fri, 24 Jul 2020 11:13:19 +0200 From: Ingo Molnar To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Peter Zijlstra , Masami Hiramatsu , Jessica Yu , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Steven Rostedt , Ingo Molnar Subject: Re: [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Message-ID: <20200724091319.GA517988@gmail.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-2-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724050553.1724168-2-jarkko.sakkinen@linux.intel.com> X-Rspamd-Queue-Id: 3DFB018039008 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Jarkko Sakkinen wrote: > Add lock_modules() and unlock_modules() wrappers for acquiring module_mutex > in order to remove the compile time dependency to it. > > Cc: linux-mm@kvack.org > Cc: Andi Kleen > Cc: Peter Zijlstra > Suggested-by: Masami Hiramatsu > Signed-off-by: Jarkko Sakkinen > --- > include/linux/module.h | 18 ++++++++++++++++++ > kernel/kprobes.c | 4 ++-- > kernel/trace/trace_kprobe.c | 4 ++-- > 3 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/include/linux/module.h b/include/linux/module.h > index 2e6670860d27..8850b9692b8f 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -705,6 +705,16 @@ static inline bool is_livepatch_module(struct module *mod) > bool is_module_sig_enforced(void); > void set_module_sig_enforced(void); > > +static inline void lock_modules(void) > +{ > + mutex_lock(&module_mutex); > +} > + > +static inline void unlock_modules(void) > +{ > + mutex_unlock(&module_mutex); > +} > + > #else /* !CONFIG_MODULES... */ > > static inline struct module *__module_address(unsigned long addr) > @@ -852,6 +862,14 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr) > return ptr; > } > > +static inline void lock_modules(void) > +{ > +} > + > +static inline void unlock_modules(void) > +{ > +} Minor namespace nit: when introducing new locking wrappers please standardize on the XYZ_lock()/XYZ_unlock() nomenclature, i.e.: modules_lock() ... modules_unlock() Similarly to the mutex_lock/unlock(&module_mutex) API that it is wrapping. Also, JFYI, the overwhelming majority of the modules related APIs use module_*(), i.e. singular - not plural, so module_lock()/module_unlock() would be the more canonical choice. (But both sound fine to me) Thanks, Ingo