From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 430B2C433E4 for ; Fri, 24 Jul 2020 09:27:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 038B42063A for ; Fri, 24 Jul 2020 09:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oUMohlqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 038B42063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 772848D0009; Fri, 24 Jul 2020 05:27:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 722226B0029; Fri, 24 Jul 2020 05:27:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EA0B8D0009; Fri, 24 Jul 2020 05:27:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 471566B0028 for ; Fri, 24 Jul 2020 05:27:51 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F2CC51801EE91 for ; Fri, 24 Jul 2020 09:27:50 +0000 (UTC) X-FDA: 77072442300.10.wind80_1e0123826f46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id C71E11DAF0 for ; Fri, 24 Jul 2020 09:27:50 +0000 (UTC) X-HE-Tag: wind80_1e0123826f46 X-Filterd-Recvd-Size: 4822 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jul 2020 09:27:50 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id dg28so6555810edb.3 for ; Fri, 24 Jul 2020 02:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t/IL7SzOQEirppaKu0kppf6/HL3sTtCWEVRaMwuH7Qs=; b=oUMohlqXje6HNqC7d0qAdNhF8nSC/reJxnDqywwzHxBm5HAEsEzTejHNXn0iX5gQRb n1HvPdZyTzneiEaA9TsDkvYS/o0U2pbSU0XB3ZuDfNMw6ASlOsC2Cw7B0jIE4e+RDeAV avUEPrQwU1w+yPA++GrzwdzAmNFTRuLcpymkYuzCQBKgzhGZ7veENgCKNKKJiaKvz3wG 6IhwOeSohyeDH6gkO5B792fOhiZerw57SxcbTg/jnFWtXSbk/CK9oMzZykP7sjQTFt+p 01nShC1wyGxpPh4Y0OB8MO/hNW9aN7w3WPK/m6rQKfDrEUm5A9SWUGpf0jduqVJPCYEZ bhRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=t/IL7SzOQEirppaKu0kppf6/HL3sTtCWEVRaMwuH7Qs=; b=G4tO9dTMsgcJzUfyxT7wpkJWm3Sp4WxHrIOk/kw5QcZln7ii66cgXAi64z49rIIxq3 zcT21B0Eifs5rr4TbIsBxXwuCsQ1KWAN1dgaAmYFuAXSRYWuh/0Ivg+l9lxgZvBEY7O8 g9+jwr2SWycgcdwcSTOHCrxHewLVJw4akaycY3BM2/bYwakuU8MqO0ABA+RS0Wqm185v P7YvmtoiwgWmU+L6hvU/i7gkDfgHasqIhW6mjFVuxKUh1RVQZda280DLNSPUibEai821 OPW44toz2J6UZH4rvRuzxXZTjE8/wvlqX0L3YZpD03NskOZmq+rBJl1cVnJWk3XQFdkk xW8g== X-Gm-Message-State: AOAM530HBJhSxpFoNFHO9dJDL2Pv1KWdQ0uPE/SprHdkZspZgDX10x7r EqEpQGWqz+GsGkuHEWgaYw4= X-Google-Smtp-Source: ABdhPJxSikPx3K43/0XJPgZZQCP8H3i2/aIVPS15slj4KVApInsWFzJo2Eyn5iCZrVt0AejTGDHcaA== X-Received: by 2002:a05:6402:2350:: with SMTP id r16mr7748316eda.62.1595582869426; Fri, 24 Jul 2020 02:27:49 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id d25sm326397edr.78.2020.07.24.02.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 02:27:48 -0700 (PDT) Date: Fri, 24 Jul 2020 11:27:46 +0200 From: Ingo Molnar To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Masami Hiramatsu , Peter Zijlstra , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Jessica Yu , Ard Biesheuvel Subject: Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free() Message-ID: <20200724092746.GD517988@gmail.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-6-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724050553.1724168-6-jarkko.sakkinen@linux.intel.com> X-Rspamd-Queue-Id: C71E11DAF0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Jarkko Sakkinen wrote: > Use text_alloc() and text_free() instead of module_alloc() and > module_memfree() when an arch provides them. > > Cc: linux-mm@kvack.org > Cc: Andi Kleen > Cc: Masami Hiramatsu > Cc: Peter Zijlstra > Signed-off-by: Jarkko Sakkinen > --- > kernel/kprobes.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 4e46d96d4e16..611fcda9f6bf 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -40,6 +40,7 @@ > #include > #include > #include > +#include > > #define KPROBE_HASH_BITS 6 > #define KPROBE_TABLE_SIZE (1 << KPROBE_HASH_BITS) > @@ -111,12 +112,20 @@ enum kprobe_slot_state { > > void __weak *alloc_insn_page(void) > { > +#ifdef CONFIG_ARCH_HAS_TEXT_ALLOC > + return text_alloc(PAGE_SIZE); > +#else > return module_alloc(PAGE_SIZE); > +#endif > } > > void __weak free_insn_page(void *page) > { > +#ifdef CONFIG_ARCH_HAS_TEXT_ALLOC > + text_free(page); > +#else > module_memfree(page); > +#endif > } I've read the observations in the other threads, but this #ifdef jungle is silly, it's a de-facto open coded text_alloc() with a module_alloc() fallback... Thanks, Ingo