From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA358C433E0 for ; Sat, 25 Jul 2020 02:03:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A20BE206C1 for ; Sat, 25 Jul 2020 02:03:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A20BE206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 031ED6B000E; Fri, 24 Jul 2020 22:03:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F230C6B0022; Fri, 24 Jul 2020 22:03:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E398F8D0002; Fri, 24 Jul 2020 22:03:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id CE6A26B000E for ; Fri, 24 Jul 2020 22:03:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 635C3182F29EC for ; Sat, 25 Jul 2020 02:03:45 +0000 (UTC) X-FDA: 77074952010.17.cars68_2b17f1126f4c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 2F0A1183525E2 for ; Sat, 25 Jul 2020 02:03:45 +0000 (UTC) X-HE-Tag: cars68_2b17f1126f4c X-Filterd-Recvd-Size: 3057 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 02:03:44 +0000 (UTC) IronPort-SDR: MOSmI86FyqqiubUXD53Z6g2DpvMbIcGtYcgPsE4O7+mGnZwYXcL3VW2af95dca6fN51JvtuQUD VCWywJCTsSkw== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="148713239" X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="148713239" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 19:03:42 -0700 IronPort-SDR: Mus7QtFxGc5I+01QQ6/9guu60jC/CwrKdo9XN2xgRYSOGv+i4qwsf+k8+c/xa5dhIrwPpu+QeU a+nojoj5j7Hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="311601525" Received: from jcrametz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.73]) by fmsmga004.fm.intel.com with ESMTP; 24 Jul 2020 19:03:34 -0700 Date: Sat, 25 Jul 2020 05:03:32 +0300 From: Jarkko Sakkinen To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Masami Hiramatsu , Andi Kleen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , "Paul E. McKenney" , Marco Elver , Babu Moger , Brian Gerst , Nayna Jain Subject: Re: [PATCH v5 3/6] arch/x86: Implement text_alloc() and text_free() Message-ID: <20200725020332.GA17052@linux.intel.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-4-jarkko.sakkinen@linux.intel.com> <20200724092258.GC517988@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724092258.GC517988@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 2F0A1183525E2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 24, 2020 at 11:22:58AM +0200, Ingo Molnar wrote: > > * Jarkko Sakkinen wrote: > > > +void text_free(void *region) > > +{ > > + /* > > + * This memory may be RO, and freeing RO memory in an interrupt is not > > + * supported by vmalloc. > > + */ > > + lockdep_assert_irqs_enabled(); > > + > > + vfree(region); > > Had to dig around a bit to find the source of this restriction. Might > make sense to clarify this comment to: > > /* > * This memory may be read-only, and freeing VM_FLUSH_RESET_PERMS memory > * in an interrupt is not supported by vmalloc. > */ This definitely clarifies and is a better explanation. I updated the commit accordingly. Thank you. > > Thanks, > > Ingo /Jarkko