From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF17FC433E0 for ; Sat, 25 Jul 2020 02:20:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA5E4206D8 for ; Sat, 25 Jul 2020 02:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA5E4206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3AC056B0028; Fri, 24 Jul 2020 22:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35CF38D0002; Fri, 24 Jul 2020 22:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2726B6B002A; Fri, 24 Jul 2020 22:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 120386B0028 for ; Fri, 24 Jul 2020 22:20:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9BB9418F63 for ; Sat, 25 Jul 2020 02:20:09 +0000 (UTC) X-FDA: 77074993338.27.list55_4a0cd5526f4c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 7328B418F2 for ; Sat, 25 Jul 2020 02:20:09 +0000 (UTC) X-HE-Tag: list55_4a0cd5526f4c X-Filterd-Recvd-Size: 2966 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Jul 2020 02:20:08 +0000 (UTC) IronPort-SDR: KbrpYVN4LdPem4/es6Vy5+/XGxSbPCieGYUr4WJgLMgkB9jtCSa6LrgrTnBcohc/FtNVWlHzwz 2d7KD8PEXi4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="235681207" X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="235681207" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 19:20:06 -0700 IronPort-SDR: E0YyHVaOEDusA67xm0IGVA/qNY+7MWnlTT1JY03GWazN1WmgsL5KI+W6b/TlwOBFN0U5C600Yf 2LrOlIXep48w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,392,1589266800"; d="scan'208";a="489391139" Received: from jcrametz-mobl.ger.corp.intel.com (HELO localhost) ([10.252.58.73]) by fmsmga005.fm.intel.com with ESMTP; 24 Jul 2020 19:20:02 -0700 Date: Sat, 25 Jul 2020 05:20:00 +0300 From: Jarkko Sakkinen To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Masami Hiramatsu , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH v5 2/6] vmalloc: Add text_alloc() and text_free() Message-ID: <20200725022000.GB17052@linux.intel.com> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> <20200724050553.1724168-3-jarkko.sakkinen@linux.intel.com> <20200724102243.GA2831654@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724102243.GA2831654@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 7328B418F2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 24, 2020 at 01:22:43PM +0300, Mike Rapoport wrote: > On Fri, Jul 24, 2020 at 08:05:49AM +0300, Jarkko Sakkinen wrote: > > Introduce functions for allocating memory for dynamic trampolines, such > > as kprobes. An arch can promote the availability of these functions with > > CONFIG_ARCH_HAS_TEXT_ALLOC. > > As it was pointed out at the discussion on the previous version [1], > text_alloc() alone won't necessarily suit other architectures. > > I don't see a point in defining a "generic" interface that apriory could > not be imeplemented by several architectures. > > [1] https://lore.kernel.org/lkml/20200714094625.1443261-1-jarkko.sakkinen@linux.intel.com/ These changes do actually acknowledge the feedback [1][2][3]. They do not interfere with module_alloc() and are fully optional. [1] https://lore.kernel.org/linux-riscv/20200714102826.GB4756@willie-the-truck/ [2] https://lore.kernel.org/linux-riscv/20200714164245.GE1551@shell.armlinux.org.uk/ [3] https://lore.kernel.org/linux-riscv/20200714135651.GA27819@linux-8ccs/ /Jarkko