[PATCH 00/15] mm: delete duplicated words and fix typos

[PATCH 00/15] mm: delete duplicated words and fix typos

[Randy Dunlap]

Drop repeated words or change them to something more readable.
Fix other typos or grammar as found near these other corrections.


Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org

 mm/compaction.c  |    2 +-
 mm/filemap.c     |    2 +-
 mm/hmm.c         |    2 +-
 mm/hugetlb.c     |    4 ++--
 mm/memcontrol.c  |    2 +-
 mm/memory.c      |    4 ++--
 mm/migrate.c     |    2 +-
 mm/nommu.c       |    4 ++--
 mm/page_alloc.c  |    6 +++---
 mm/shmem.c       |    2 +-
 mm/slab_common.c |    2 +-
 mm/usercopy.c    |    2 +-
 mm/vmscan.c      |    4 ++--
 mm/zpool.c       |    8 ++++----
 mm/zsmalloc.c    |    2 +-
 15 files changed, 24 insertions(+), 24 deletions(-)

[PATCH 01/15] mm: compaction.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "a".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/compaction.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/compaction.c
+++ linux-next-20200731/mm/compaction.c
@@ -1477,7 +1477,7 @@ static void isolate_freepages(struct com
 	 * this pfn aligned down to the pageblock boundary, because we do
 	 * block_start_pfn -= pageblock_nr_pages in the for loop.
 	 * For ending point, take care when isolating in last pageblock of a
-	 * a zone which ends in the middle of a pageblock.
+	 * zone which ends in the middle of a pageblock.
 	 * The low boundary is the end of the pageblock the migration scanner
 	 * is using.
 	 */

[PATCH 02/15] mm: filemap.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "the".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/filemap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/filemap.c
+++ linux-next-20200731/mm/filemap.c
@@ -2848,7 +2848,7 @@ filler:
 	 * Case a, the page will be up to date when the page is unlocked.
 	 *    There is no need to serialise on the page lock here as the page
 	 *    is pinned so the lock gives no additional protection. Even if the
-	 *    the page is truncated, the data is still valid if PageUptodate as
+	 *    page is truncated, the data is still valid if PageUptodate as
 	 *    it's a race vs truncate race.
 	 * Case b, the page will not be up to date
 	 * Case c, the page may be truncated but in itself, the data may still

[PATCH 03/15] mm: hmm.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "pages".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/hmm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/hmm.c
+++ linux-next-20200731/mm/hmm.c
@@ -250,7 +250,7 @@ static int hmm_vma_handle_pte(struct mm_
 		swp_entry_t entry = pte_to_swp_entry(pte);
 
 		/*
-		 * Never fault in device private pages pages, but just report
+		 * Never fault in device private pages, but just report
 		 * the PFN even if not present.
 		 */
 		if (hmm_is_device_private_entry(range, entry)) {

[PATCH 04/15] mm: hugetlb.c: delete duplicated words

[Randy Dunlap]

Drop the repeated word "the" in two places.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200731.orig/mm/hugetlb.c
+++ linux-next-20200731/mm/hugetlb.c
@@ -134,7 +134,7 @@ void hugepage_put_subpool(struct hugepag
 /*
  * Subpool accounting for allocating and reserving pages.
  * Return -ENOMEM if there are not enough resources to satisfy the
- * the request.  Otherwise, return the number of pages by which the
+ * request.  Otherwise, return the number of pages by which the
  * global pools must be adjusted (upward).  The returned value may
  * only be different than the passed value (delta) in the case where
  * a subpool minimum size must be maintained.
@@ -2174,7 +2174,7 @@ static void return_unused_surplus_pages(
 	 * evenly across all nodes with memory. Iterate across these nodes
 	 * until we can no longer free unreserved surplus pages. This occurs
 	 * when the nodes with surplus pages have no free pages.
-	 * free_pool_huge_page() will balance the the freed pages across the
+	 * free_pool_huge_page() will balance the freed pages across the
 	 * on-line nodes with memory and will handle the hstate accounting.
 	 *
 	 * Note that we decrement resv_huge_pages as we free the pages.  If

Re: [PATCH 04/15] mm: hugetlb.c: delete duplicated words

[Mike Kravetz]

On 8/1/20 10:38 AM, Randy Dunlap wrote:
> Drop the repeated word "the" in two places.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> To: linux-mm@kvack.org
> ---
>  mm/hugetlb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Randy,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

[PATCH 05/15] mm: memcontrol.c: delete duplicated words

[Randy Dunlap]

Drop the repeated word "down".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/memcontrol.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/memcontrol.c
+++ linux-next-20200731/mm/memcontrol.c
@@ -2416,7 +2416,7 @@ static void high_work_func(struct work_s
  *
  * - MEMCG_DELAY_PRECISION_SHIFT: Extra precision bits while translating the
  *   overage ratio to a delay.
- * - MEMCG_DELAY_SCALING_SHIFT: The number of bits to scale down down the
+ * - MEMCG_DELAY_SCALING_SHIFT: The number of bits to scale down the
  *   proposed penalty in order to reduce to a reasonable number of jiffies, and
  *   to produce a reasonable delay curve.
  *

[PATCH 06/15] mm: memory.c: delete duplicated words

[Randy Dunlap]

Drop the repeated word "to" in two places.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/memory.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200731.orig/mm/memory.c
+++ linux-next-20200731/mm/memory.c
@@ -1802,7 +1802,7 @@ out_unlock:
  * @pfn: source kernel pfn
  * @pgprot: pgprot flags for the inserted page
  *
- * This is exactly like vmf_insert_pfn(), except that it allows drivers to
+ * This is exactly like vmf_insert_pfn(), except that it allows drivers
  * to override pgprot on a per-page basis.
  *
  * This only makes sense for IO mappings, and it makes no sense for
@@ -1938,7 +1938,7 @@ static vm_fault_t __vm_insert_mixed(stru
  * @pfn: source kernel pfn
  * @pgprot: pgprot flags for the inserted page
  *
- * This is exactly like vmf_insert_mixed(), except that it allows drivers to
+ * This is exactly like vmf_insert_mixed(), except that it allows drivers
  * to override pgprot on a per-page basis.
  *
  * Typically this function should be used by drivers to set caching- and

[PATCH 07/15] mm: migrate.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "and".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/migrate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/migrate.c
+++ linux-next-20200731/mm/migrate.c
@@ -2709,7 +2709,7 @@ restore:
 
 /**
  * migrate_vma_setup() - prepare to migrate a range of memory
- * @args: contains the vma, start, and and pfns arrays for the migration
+ * @args: contains the vma, start, and pfns arrays for the migration
  *
  * Returns: negative errno on failures, 0 when 0 or more pages were migrated
  * without an error.

[PATCH 08/15] mm: nommu.c: delete duplicated words

[Randy Dunlap]

Drop the repeated word "that" in two places.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/nommu.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200731.orig/mm/nommu.c
+++ linux-next-20200731/mm/nommu.c
@@ -1762,8 +1762,8 @@ EXPORT_SYMBOL_GPL(access_process_vm);
  * @newsize: The proposed filesize of the inode
  *
  * Check the shared mappings on an inode on behalf of a shrinking truncate to
- * make sure that that any outstanding VMAs aren't broken and then shrink the
- * vm_regions that extend that beyond so that do_mmap() doesn't
+ * make sure that any outstanding VMAs aren't broken and then shrink the
+ * vm_regions that extend beyond so that do_mmap() doesn't
  * automatically grant mappings that are too large.
  */
 int nommu_shrink_inode_mappings(struct inode *inode, size_t size,

[PATCH 09/15] mm: page_alloc.c: delete or fix duplicated words

[Randy Dunlap]

Drop the repeated word "them" and "that".
Change "the the" to "to the".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/page_alloc.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20200731.orig/mm/page_alloc.c
+++ linux-next-20200731/mm/page_alloc.c
@@ -4295,7 +4295,7 @@ retry:
 	/*
 	 * If an allocation failed after direct reclaim, it could be because
 	 * pages are pinned on the per-cpu lists or in high alloc reserves.
-	 * Shrink them them and try again
+	 * Shrink them and try again
 	 */
 	if (!page && !drained) {
 		unreserve_highatomic_pageblock(ac, false);
@@ -6205,7 +6205,7 @@ static int zone_batchsize(struct zone *z
  * locking.
  *
  * Any new users of pcp->batch and pcp->high should ensure they can cope with
- * those fields changing asynchronously (acording the the above rule).
+ * those fields changing asynchronously (acording to the above rule).
  *
  * mutex_is_locked(&pcp_batch_high_lock) required when calling this function
  * outside of boot time (or some other assurance that no concurrent updaters
@@ -8216,7 +8216,7 @@ void *__init alloc_large_system_hash(con
  * race condition. So you can't expect this function should be exact.
  *
  * Returns a page without holding a reference. If the caller wants to
- * dereference that page (e.g., dumping), it has to make sure that that it
+ * dereference that page (e.g., dumping), it has to make sure that it
  * cannot get removed (e.g., via memory unplug) concurrently.
  *
  */

[PATCH 10/15] mm: shmem.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "the".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/shmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/shmem.c
+++ linux-next-20200731/mm/shmem.c
@@ -1686,7 +1686,7 @@ static int shmem_replace_page(struct pag
  * Swap in the page pointed to by *pagep.
  * Caller has to make sure that *pagep contains a valid swapped page.
  * Returns 0 and the page in pagep if success. On failure, returns the
- * the error code and NULL in *pagep.
+ * error code and NULL in *pagep.
  */
 static int shmem_swapin_page(struct inode *inode, pgoff_t index,
 			     struct page **pagep, enum sgp_type sgp,

[PATCH 11/15] mm: slab_common.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "and".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/slab_common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/slab_common.c
+++ linux-next-20200731/mm/slab_common.c
@@ -419,7 +419,7 @@ static void slab_caches_to_rcu_destroy_w
 	/*
 	 * On destruction, SLAB_TYPESAFE_BY_RCU kmem_caches are put on the
 	 * @slab_caches_to_rcu_destroy list.  The slab pages are freed
-	 * through RCU and and the associated kmem_cache are dereferenced
+	 * through RCU and the associated kmem_cache are dereferenced
 	 * while freeing the pages, so the kmem_caches should be freed only
 	 * after the pending RCU operations are finished.  As rcu_barrier()
 	 * is a pretty slow operation, we batch all pending destructions

[PATCH 12/15] mm: usercopy.c: delete duplicated word

[Randy Dunlap]

Drop the repeated word "the".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/usercopy.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/usercopy.c
+++ linux-next-20200731/mm/usercopy.c
@@ -43,7 +43,7 @@ static noinline int check_stack_object(c
 
 	/*
 	 * Reject: object partially overlaps the stack (passing the
-	 * the check above means at least one end is within the stack,
+	 * check above means at least one end is within the stack,
 	 * so if this check fails, the other end is outside the stack).
 	 */
 	if (obj < stack || stackend < obj + len)

[PATCH 13/15] mm: vmscan.c: delete or fix duplicated words

[Randy Dunlap]

Drop the repeated word "marked".
Change "time time" to "same time".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/vmscan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20200731.orig/mm/vmscan.c
+++ linux-next-20200731/mm/vmscan.c
@@ -2798,7 +2798,7 @@ again:
 			set_bit(PGDAT_DIRTY, &pgdat->flags);
 
 		/*
-		 * If kswapd scans pages marked marked for immediate
+		 * If kswapd scans pages marked for immediate
 		 * reclaim and under writeback (nr_immediate), it
 		 * implies that pages are cycling through the LRU
 		 * faster than they are written so also forcibly stall.
@@ -3379,7 +3379,7 @@ static bool pgdat_watermark_boosted(pg_d
 	/*
 	 * Check for watermark boosts top-down as the higher zones
 	 * are more likely to be boosted. Both watermarks and boosts
-	 * should not be checked at the time time as reclaim would
+	 * should not be checked at the same time as reclaim would
 	 * start prematurely when there is no boosting and a lower
 	 * zone is balanced.
 	 */

[PATCH 14/15] mm: zpool.c: delete duplicated word and fix grammar

[Randy Dunlap]

Drop the repeated word "if".
Fix subject/verb agreement.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/zpool.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20200731.orig/mm/zpool.c
+++ linux-next-20200731/mm/zpool.c
@@ -239,15 +239,15 @@ const char *zpool_get_type(struct zpool
 }
 
 /**
- * zpool_malloc_support_movable() - Check if the zpool support
- * allocate movable memory
+ * zpool_malloc_support_movable() - Check if the zpool supports
+ *	allocating movable memory
  * @zpool:	The zpool to check
  *
- * This returns if the zpool support allocate movable memory.
+ * This returns if the zpool supports allocating movable memory.
  *
  * Implementations must guarantee this to be thread-safe.
  *
- * Returns: true if if the zpool support allocate movable memory, false if not
+ * Returns: true if the zpool supports allocating movable memory, false if not
  */
 bool zpool_malloc_support_movable(struct zpool *zpool)
 {

[PATCH 15/15] mm: zsmalloc.c: fix duplicated words

[Randy Dunlap]

Change "as as" to "as a".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
To: linux-mm@kvack.org
---
 mm/zsmalloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200731.orig/mm/zsmalloc.c
+++ linux-next-20200731/mm/zsmalloc.c
@@ -79,7 +79,7 @@
 
 /*
  * Object location (<PFN>, <obj_idx>) is encoded as
- * as single (unsigned long) handle value.
+ * a single (unsigned long) handle value.
  *
  * Note that object index <obj_idx> starts from 0.
  *

Re: [PATCH 00/15] mm: delete duplicated words and fix typos

[Zi Yan]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On 1 Aug 2020, at 13:38, Randy Dunlap wrote:

> Drop repeated words or change them to something more readable.
> Fix other typos or grammar as found near these other corrections.
>
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> To: linux-mm@kvack.org
>
>  mm/compaction.c  |    2 +-
>  mm/filemap.c     |    2 +-
>  mm/hmm.c         |    2 +-
>  mm/hugetlb.c     |    4 ++--
>  mm/memcontrol.c  |    2 +-
>  mm/memory.c      |    4 ++--
>  mm/migrate.c     |    2 +-
>  mm/nommu.c       |    4 ++--
>  mm/page_alloc.c  |    6 +++---
>  mm/shmem.c       |    2 +-
>  mm/slab_common.c |    2 +-
>  mm/usercopy.c    |    2 +-
>  mm/vmscan.c      |    4 ++--
>  mm/zpool.c       |    8 ++++----
>  mm/zsmalloc.c    |    2 +-
>  15 files changed, 24 insertions(+), 24 deletions(-)

The whole series looks good to me. Thanks.

Reviewed-by: Zi Yan <ziy@nvidia.com>

—
Best Regards,
Yan Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]