From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 492FDC433DF for ; Sun, 2 Aug 2020 21:44:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1021B20738 for ; Sun, 2 Aug 2020 21:44:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="qHldnjF7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1021B20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2EE98D00D1; Sun, 2 Aug 2020 17:44:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADFBB8D00AA; Sun, 2 Aug 2020 17:44:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CEE58D00D1; Sun, 2 Aug 2020 17:44:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 8368E8D00AA for ; Sun, 2 Aug 2020 17:44:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0E46F3623 for ; Sun, 2 Aug 2020 21:44:04 +0000 (UTC) X-FDA: 77106956808.03.power52_120e4ab26f98 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id DC93728A4EA for ; Sun, 2 Aug 2020 21:44:03 +0000 (UTC) X-HE-Tag: power52_120e4ab26f98 X-Filterd-Recvd-Size: 4493 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sun, 2 Aug 2020 21:44:03 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id i10so2847507ljn.2 for ; Sun, 02 Aug 2020 14:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W+JW9/qURXxdJHu00PKJzuTat8D6D0UTqBo2IDM73ms=; b=qHldnjF7bttAYl+4vR9WYNVBGhIodj7vux22J4S0paJxxX4KkZ8N7egol8vHxfmd64 +LfdWqs02/fD0tJQPYV22bCXkE0X+YPL0YYg94IIMKswYYYk9BT7gbliSYgxd+o5jw8e fvyu/cs/74qRenHzx5R1FClEPRSomH5g9rkAkzX5KIV3dXLGPVRCdkr39kWDlMmcAdKD xBjBvkL0ssDx62oO2dY5J0as+hohy1WhRtiyfh6Ur4Mnulur072oiwX2i3qw1gz9B/S8 +jg+danNDHtYnULYSj3ptjL+x1ALX/jSyBwV/8gWL1T7JlXCEpXrH/5oj0zu83cisNLZ FYCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W+JW9/qURXxdJHu00PKJzuTat8D6D0UTqBo2IDM73ms=; b=pHXGDpyU9izp6j3HhNzaWsqkY60ESp20n8tZvskOucvELDP30Ey23g9cQGgJZeMJ5/ ++Uw//njMSfyieXMyAPMeNWJI1qz2nH7MzHq7hlaSdZ1Sg4YeKF8IpFIcRMrvfJzPvWX qXke7DAQppQo5ylV7hpUwgnHvmWSEgwDOUcddqbEgxJRVUF35efWC/YiBGlRLrCkVVB6 cYeAU0zuyl7twEnkCmvL8Vle7hCXXh0/DY2lAoAD22/LXpPLO6H27Bea0mzY9obEj+jo VLfHsPNhFz+IT/qytdYemqQCzgDFnuK93V2jqg4AZ4/9EbxjmuP1lpI/kKJpI6evC24M TCtA== X-Gm-Message-State: AOAM531xzvROzvsvK02IVlGRqFLtWKtaffp58xxyjKRpl3MMtmhjaCZn wX7JtKiZ7K9JTUVLJBva/In45g== X-Google-Smtp-Source: ABdhPJyvaMeTwdlHiWWUa3QZPEsnvfODeHluEuNvzw9qeydsh8K0hkI9EM4bXVwrQx8q87PK2vlwaA== X-Received: by 2002:a05:651c:1104:: with SMTP id d4mr6859667ljo.164.1596404641969; Sun, 02 Aug 2020 14:44:01 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id a19sm3989856lff.25.2020.08.02.14.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 14:44:01 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 0AEBC102BA1; Mon, 3 Aug 2020 00:44:08 +0300 (+03) Date: Mon, 3 Aug 2020 00:44:08 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Andrea Arcangeli , Song Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] khugepaged: retract_page_tables() remember to test exit Message-ID: <20200802214408.patvlf3sghro3nhi@box> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DC93728A4EA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 02, 2020 at 12:16:53PM -0700, Hugh Dickins wrote: > Only once have I seen this scenario (and forgot even to notice what > forced the eventual crash): a sequence of "BUG: Bad page map" alerts > from vm_normal_page(), from zap_pte_range() servicing exit_mmap(); > pmd:00000000, pte values corresponding to data in physical page 0. > > The pte mappings being zapped in this case were supposed to be from a > huge page of ext4 text (but could as well have been shmem): my belief > is that it was racing with collapse_file()'s retract_page_tables(), > found *pmd pointing to a page table, locked it, but *pmd had become > 0 by the time start_pte was decided. > > In most cases, that possibility is excluded by holding mmap lock; > but exit_mmap() proceeds without mmap lock. Most of what's run by > khugepaged checks khugepaged_test_exit() after acquiring mmap lock: > khugepaged_collapse_pte_mapped_thps() and hugepage_vma_revalidate() > do so, for example. But retract_page_tables() did not: fix that > (using an mm variable instead of vma->vm_mm repeatedly). Hm. I'm not sure I follow. vma->vm_mm has to be valid as long as we hold i_mmap lock, no? Unlinking a VMA requires it. -- Kirill A. Shutemov