From: Michal Hocko <mhocko@suse.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: longman@redhat.com, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, memcg: do full scan initially in force_empty
Date: Mon, 3 Aug 2020 16:37:10 +0200 [thread overview]
Message-ID: <20200803143710.GS5174@dhcp22.suse.cz> (raw)
In-Reply-To: <CALOAHbBFCtTPXK-VwT1uWG7QF-STz6S988=+Ka7FvTn6swtnoA@mail.gmail.com>
On Mon 03-08-20 22:26:10, Yafang Shao wrote:
> On Mon, Aug 3, 2020 at 10:18 PM Yafang Shao <laoar.shao@gmail.com> wrote:
[...]
> > You can use memcg limits (e.g. memory high) to pro-actively reclaim
> > excess memory. Have you tried that?
>
> The memcg limit not only reclaim the slabs, but also reclaim the pagecaches.
True but drop_cache doesn't distinguish different kind of objects
either. The reclaim will simply try to drop unused cache. All or nothing
behavior of drop_caches is exactly what I dislike about the interface.
Memory reclaim can at least consider age and reflect the general usage
pattern.
> Furthermore, there is no per-memcg vm.vfs_cache_pressure neither.
Why does that matter?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-08-03 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 7:40 [PATCH] mm, memcg: do full scan initially in force_empty Yafang Shao
2020-07-30 11:26 ` Michal Hocko
2020-07-31 1:50 ` Yafang Shao
2020-08-03 10:12 ` Michal Hocko
2020-08-03 13:20 ` Yafang Shao
2020-08-03 13:56 ` Michal Hocko
2020-08-03 14:18 ` Yafang Shao
2020-08-03 14:26 ` Yafang Shao
2020-08-03 14:37 ` Michal Hocko [this message]
2020-08-03 14:34 ` Michal Hocko
2020-08-03 15:26 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803143710.GS5174@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).