From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Yafang Shao <laoar.shao@gmail.com>,
hch@infradead.org, darrick.wong@oracle.com, mhocko@kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, Yafang Shao <shaoyafang@didiglobal.com>
Subject: Re: [PATCH v4 1/2] xfs: avoid double restore PF_MEMALLOC_NOFS if transaction reservation fails
Date: Wed, 5 Aug 2020 11:28:09 +1000 [thread overview]
Message-ID: <20200805012809.GF2114@dread.disaster.area> (raw)
In-Reply-To: <20200804235038.GL23808@casper.infradead.org>
On Wed, Aug 05, 2020 at 12:50:38AM +0100, Matthew Wilcox wrote:
> On Wed, Aug 05, 2020 at 09:20:05AM +1000, Dave Chinner wrote:
> > Also, please convert these to memalloc_nofs_save()/restore() calls
> > as that is the way we are supposed to mark these regions now.
>
> I have a patch for that!
Did you compile test it? :)
> ---
> fs/xfs/kmem.c | 2 +-
> fs/xfs/xfs_aops.c | 4 ++--
> fs/xfs/xfs_buf.c | 2 +-
> fs/xfs/xfs_linux.h | 6 ------
> fs/xfs/xfs_trans.c | 14 +++++++-------
> fs/xfs/xfs_trans.h | 2 +-
> 6 files changed, 12 insertions(+), 18 deletions(-)
.....
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index 9f70d2f68e05..e1daf242a53b 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -104,12 +104,6 @@ typedef __u32 xfs_nlink_t;
> #define current_cpu() (raw_smp_processor_id())
> #define current_pid() (current->pid)
> #define current_test_flags(f) (current->flags & (f))
> -#define current_set_flags_nested(sp, f) \
> - (*(sp) = current->flags, current->flags |= (f))
> -#define current_clear_flags_nested(sp, f) \
> - (*(sp) = current->flags, current->flags &= ~(f))
> -#define current_restore_flags_nested(sp, f) \
> - (current->flags = ((current->flags & ~(f)) | (*(sp) & (f))))
current_set_flags_nested() and current_restore_flags_nested()
are used in xfs_btree_split_worker() in fs/xfs/libxfs/xfs_btree.c
and that's not a file you modified in this patch...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-08-05 1:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 15:46 [PATCH v4 0/2] void xfs transaction reservation recursion Yafang Shao
2020-08-01 15:46 ` [PATCH v4 1/2] xfs: avoid double restore PF_MEMALLOC_NOFS if transaction reservation fails Yafang Shao
2020-08-04 23:20 ` Dave Chinner
2020-08-04 23:50 ` Matthew Wilcox
2020-08-05 1:28 ` Dave Chinner [this message]
2020-08-07 4:05 ` Yafang Shao
2020-08-01 15:46 ` [PATCH v4 2/2] xfs: avoid transaction reservation recursion Yafang Shao
2020-08-04 23:35 ` Dave Chinner
2020-08-07 4:11 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805012809.GF2114@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=shaoyafang@didiglobal.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).