From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CE3C433E0 for ; Fri, 7 Aug 2020 06:17:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE642221E5 for ; Fri, 7 Aug 2020 06:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mdSCBu1G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE642221E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55C4A8D0008; Fri, 7 Aug 2020 02:17:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BBE48D0002; Fri, 7 Aug 2020 02:17:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AC678D0008; Fri, 7 Aug 2020 02:17:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 25AD18D0002 for ; Fri, 7 Aug 2020 02:17:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1DAEE3641 for ; Fri, 7 Aug 2020 06:17:28 +0000 (UTC) X-FDA: 77122765776.01.bee07_0808ea326fbe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id E83611005147B for ; Fri, 7 Aug 2020 06:17:27 +0000 (UTC) X-HE-Tag: bee07_0808ea326fbe X-Filterd-Recvd-Size: 2663 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 06:17:27 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CFFC22C9F; Fri, 7 Aug 2020 06:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596781046; bh=xzzxhU/8SiRsBrTPD9nwPf1PmQq1mdHEor5/lZyDKIs=; h=Date:From:To:Subject:In-Reply-To:From; b=mdSCBu1GrFNJGlkgjqRrkwUYsbUbI70jxufGxBdzhM5OCTQHrdHD1V0aNkPrqrLmV XCJml3xkGDstDFAX9Frg6ak1nWJB2tEToOGPTFh2tOdJvNBRxcCsBVotWalTwVi6ny Z2lIx2lRqfd6KD6YUcaTEcXaodTX+ZgFICbJXk+U= Date: Thu, 06 Aug 2020 23:17:25 -0700 From: Andrew Morton To: akpm@linux-foundation.org, chris@chrisdown.name, christian.brauner@ubuntu.com, gaurav1086@gmail.com, guro@fb.com, linux-mm@kvack.org, mkoutny@suse.com, mm-commits@vger.kernel.org, shuah@kernel.org, tj@kernel.org, torvalds@linux-foundation.org Subject: [patch 007/163] tools/testing/selftests/cgroup/cgroup_util.c: cg_read_strcmp: fix null pointer dereference Message-ID: <20200807061725.WdE4MoFqu%akpm@linux-foundation.org> In-Reply-To: <20200806231643.a2711a608dd0f18bff2caf2b@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: E83611005147B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Gaurav Singh Subject: tools/testing/selftests/cgroup/cgroup_util.c: cg_read_strcmp: fix null pointer dereference Haven't reproduced this issue. This PR is does a minor code cleanup. Link: http://lkml.kernel.org/r/20200726013808.22242-1-gaurav1086@gmail.com Signed-off-by: Gaurav Singh Reviewed-by: Andrew Morton Cc: Shuah Khan Cc: Tejun Heo Cc: Michal Koutn Cc: Roman Gushchin Cc: Christian Brauner Cc: Chris Down Signed-off-by: Andrew Morton --- tools/testing/selftests/cgroup/cgroup_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/cgroup/cgroup_util.c~cg_read_strcmp-fix-null-pointer-dereference +++ a/tools/testing/selftests/cgroup/cgroup_util.c @@ -106,7 +106,7 @@ int cg_read_strcmp(const char *cgroup, c /* Handle the case of comparing against empty string */ if (!expected) - size = 32; + return -1; else size = strlen(expected) + 1; _