From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B68C433E0 for ; Fri, 7 Aug 2020 12:59:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 31A7720866 for ; Fri, 7 Aug 2020 12:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aToIgu77" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31A7720866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B786F8D008F; Fri, 7 Aug 2020 08:59:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2A708D003B; Fri, 7 Aug 2020 08:59:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A173A8D008F; Fri, 7 Aug 2020 08:59:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 890CF8D003B for ; Fri, 7 Aug 2020 08:59:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 33FE91DF8 for ; Fri, 7 Aug 2020 12:59:44 +0000 (UTC) X-FDA: 77123779488.19.fly99_490612426fc0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id B30AB1ACC30 for ; Fri, 7 Aug 2020 12:59:38 +0000 (UTC) X-HE-Tag: fly99_490612426fc0 X-Filterd-Recvd-Size: 3211 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 12:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596805177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EJpiX5twwNq1/bCnTJVgk9REEVNsOlu4rjWGfcA22Ss=; b=aToIgu77X+bNqW1Ob3RYrTY85x95DH7hI5pRrouG9PHztOGzrduxC+WO1lbaUFrGFBhI5z NdJFNunPbaIaaPeVMp7+iv7u3qJAXUs+yuWTTgMfFBahWV95WFQ+xBmhiDFHGt0Oi5vOUD eLbDIeEqv+wJxVfASb9m6Gz7Gch3Qj8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-MLPTm4m5N8eJSj4s12nLTg-1; Fri, 07 Aug 2020 08:59:33 -0400 X-MC-Unique: MLPTm4m5N8eJSj4s12nLTg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B47B0800486; Fri, 7 Aug 2020 12:59:32 +0000 (UTC) Received: from localhost (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD7D6756B3; Fri, 7 Aug 2020 12:59:31 +0000 (UTC) Date: Fri, 7 Aug 2020 20:59:28 +0800 From: Baoquan He To: Wei Yang Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] mm/hugetlb: remove redundant huge_pte_alloc() in hugetlb_fault() Message-ID: <20200807125928.GQ14854@MiWiFi-R3L-srv> References: <20200807091251.12129-1-richard.weiyang@linux.alibaba.com> <20200807091251.12129-7-richard.weiyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807091251.12129-7-richard.weiyang@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Queue-Id: B30AB1ACC30 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/07/20 at 05:12pm, Wei Yang wrote: > Before proper processing, huge_pte_alloc() would be called > un-conditionally. It is not necessary to do this when ptep is NULL. > > Signed-off-by: Wei Yang > --- > mm/hugetlb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index f5f04e89000d..fb09e5a83c39 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4534,10 +4534,6 @@ vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, > } else if (unlikely(is_hugetlb_entry_hwpoisoned(entry))) > return VM_FAULT_HWPOISON_LARGE | > VM_FAULT_SET_HINDEX(hstate_index(h)); > - } else { > - ptep = huge_pte_alloc(mm, haddr, huge_page_size(h)); > - if (!ptep) > - return VM_FAULT_OOM; Right, seems a relic from Mike's i_mmap_rwsem handling patches. Reviewed-by: Baoquan He > } > > /* > -- > 2.20.1 (Apple Git-117) > >