From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADA6C433DF for ; Fri, 7 Aug 2020 14:28:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9E652075D for ; Fri, 7 Aug 2020 14:28:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9E652075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 823F96B0022; Fri, 7 Aug 2020 10:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D50E8D0002; Fri, 7 Aug 2020 10:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EBF98D0001; Fri, 7 Aug 2020 10:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 5A08A6B0022 for ; Fri, 7 Aug 2020 10:28:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 17D6C180AD801 for ; Fri, 7 Aug 2020 14:28:46 +0000 (UTC) X-FDA: 77124003852.04.grade41_330be3c26fc1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id DC39A800FFC2 for ; Fri, 7 Aug 2020 14:28:45 +0000 (UTC) X-HE-Tag: grade41_330be3c26fc1 X-Filterd-Recvd-Size: 2838 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 7 Aug 2020 14:28:44 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01419;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0U50laYt_1596810517; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U50laYt_1596810517) by smtp.aliyun-inc.com(127.0.0.1); Fri, 07 Aug 2020 22:28:38 +0800 Date: Fri, 7 Aug 2020 22:28:37 +0800 From: Wei Yang To: Baoquan He Cc: Wei Yang , mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] mm/hugetlb: remove the redundant check on non_swap_entry() Message-ID: <20200807142837.GB14692@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200807091251.12129-1-richard.weiyang@linux.alibaba.com> <20200807091251.12129-6-richard.weiyang@linux.alibaba.com> <20200807125550.GP14854@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807125550.GP14854@MiWiFi-R3L-srv> X-Rspamd-Queue-Id: DC39A800FFC2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000251, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 07, 2020 at 08:55:50PM +0800, Baoquan He wrote: >On 08/07/20 at 05:12pm, Wei Yang wrote: >> Migration and hwpoison entry is a subset of non_swap_entry(). >> >> Remove the redundant check on non_swap_entry(). >> >> Signed-off-by: Wei Yang > >Hmm, I have posted one patch to do the same thing, got reivewed by >people. > >https://lore.kernel.org/linux-mm/20200723104636.GS32539@MiWiFi-R3L-srv/ > Nice >> --- >> mm/hugetlb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index d775e514eb2e..f5f04e89000d 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3778,7 +3778,7 @@ bool is_hugetlb_entry_migration(pte_t pte) >> if (huge_pte_none(pte) || pte_present(pte)) >> return false; >> swp = pte_to_swp_entry(pte); >> - if (non_swap_entry(swp) && is_migration_entry(swp)) >> + if (is_migration_entry(swp)) >> return true; >> else >> return false; >> @@ -3791,7 +3791,7 @@ static int is_hugetlb_entry_hwpoisoned(pte_t pte) >> if (huge_pte_none(pte) || pte_present(pte)) >> return 0; >> swp = pte_to_swp_entry(pte); >> - if (non_swap_entry(swp) && is_hwpoison_entry(swp)) >> + if (is_hwpoison_entry(swp)) >> return 1; >> else >> return 0; >> -- >> 2.20.1 (Apple Git-117) >> >> -- Wei Yang Help you, Help me