From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB272C433E1 for ; Mon, 10 Aug 2020 09:52:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6411820734 for ; Mon, 10 Aug 2020 09:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6411820734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B60126B0006; Mon, 10 Aug 2020 05:52:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B10446B0007; Mon, 10 Aug 2020 05:52:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4D116B0008; Mon, 10 Aug 2020 05:52:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 8E9E76B0006 for ; Mon, 10 Aug 2020 05:52:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1AF07824805A for ; Mon, 10 Aug 2020 09:52:04 +0000 (UTC) X-FDA: 77134192968.10.deer77_2b0eef926fd9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id D5C3816A4A4 for ; Mon, 10 Aug 2020 09:52:03 +0000 (UTC) X-HE-Tag: deer77_2b0eef926fd9 X-Filterd-Recvd-Size: 4005 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Aug 2020 09:52:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 35B72AD65; Mon, 10 Aug 2020 09:52:22 +0000 (UTC) Date: Mon, 10 Aug 2020 11:52:01 +0200 From: Michal Hocko To: Alex Shi Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcg: remove useless check on page->mem_cgroup Message-ID: <20200810095201.GC4773@dhcp22.suse.cz> References: <1596166480-22814-1-git-send-email-alex.shi@linux.alibaba.com> <20200731151655.GB491801@cmpxchg.org> <9338716f-ca0e-057f-8d94-03e2b3f70281@linux.alibaba.com> <20200803081815.GD5174@dhcp22.suse.cz> <92dd8e68-8095-72c5-0144-2a084e4d5993@linux.alibaba.com> <5622ef68-5e70-d1a9-d1be-b45411b6be5c@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5622ef68-5e70-d1a9-d1be-b45411b6be5c@linux.alibaba.com> X-Rspamd-Queue-Id: D5C3816A4A4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 05-08-20 21:02:30, Alex Shi wrote: >=20 >=20 > =E5=9C=A8 2020/8/5 =E4=B8=8B=E5=8D=888:28, Alex Shi =E5=86=99=E9=81=93: > > The last patch has a problem on define. this version could fix it. > >=20 > > BTW, I see some !memcg happens when MEMCG compilered but disabled by = cgroup_disable > >=20 > >=20 > > [ 94.657666] ---[ end trace f1f34bfc3b32ed2f ]--- > > [ 95.138995] anon flags: 0x5005b48008000d(locked|uptodate|dirty|swa= pbacked) > > [ 95.146220] raw: 005005b48008000d dead000000000100 dead00000000012= 2 ffff8897c7c76ad1 > > [ 95.154549] raw: 0000000000000022 0000000000000000 000000020000000= 0 0000000000000000 > > [ 95.162876] page dumped because: VM_WARN_ON_ONCE_PAGE(!memcg) > >=20 > >=20 >=20 > The following patch may helpful. >=20 > >From 8bfb26a2e37e08dc61d20212bcfa5812a367ba94 Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Wed, 5 Aug 2020 20:32:12 +0800 > Subject: [PATCH] mm/memcg: don't try charge swap if memcg disabled >=20 > If we disabled memcg by cgroup_disable=3Dmemory, the swap charges are > still called. Let's return from the funcs earlier and keep WARN_ON > monitor. Do I get it right that this is on top of your patch to remove the memcg check or a preparatory work? Both are good but it would be better to call that out specifically for clarity (along with the warning if that is a follow up fix). > Signed-off-by: Alex Shi > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Michal Hocko > --- > mm/memcontrol.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index cb07a48d53aa..65f2b42d25af 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7163,6 +7163,9 @@ void mem_cgroup_swapout(struct page *page, swp_en= try_t entry) > VM_BUG_ON_PAGE(PageLRU(page), page); > VM_BUG_ON_PAGE(page_count(page), page); > =20 > + if (mem_cgroup_disabled()) > + return; > + > if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) > return; > =20 > @@ -7228,6 +7231,9 @@ int mem_cgroup_try_charge_swap(struct page *page,= swp_entry_t entry) > struct mem_cgroup *memcg; > unsigned short oldid; > =20 > + if (mem_cgroup_disabled()) > + return 0; > + > if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > return 0; > =20 > --=20 > 1.8.3.1 --=20 Michal Hocko SUSE Labs