From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-mm@kvack.org, Harish Sriram <harish@linux.ibm.com>
Subject: Re: [PATCH] mm/vunmap: Add cond_resched() in vunmap_pmd_range
Date: Mon, 10 Aug 2020 21:46:55 -0700 [thread overview]
Message-ID: <20200810214655.a3f82fc8ccd671a392164a09@linux-foundation.org> (raw)
In-Reply-To: <20200807075933.310240-1-aneesh.kumar@linux.ibm.com>
On Fri, 7 Aug 2020 13:29:33 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
> Like zap_pte_range add cond_resched so that we can avoid softlockups as reported
> below. On non-preemptible kernel with large I/O map region (like the one we get
> when using persistent memory with sector mode), an unmap of the namespace can report
> below softlockups.
>
> ...
>
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -102,6 +102,8 @@ static void vunmap_pmd_range(pud_t *pud, unsigned long addr, unsigned long end,
> if (pmd_none_or_clear_bad(pmd))
> continue;
> vunmap_pte_range(pmd, addr, next, mask);
> +
> + cond_resched();
> } while (pmd++, addr = next, addr != end);
> }
That looks sane. I'll aim for merging it in 5.9-rc2ish, with a
cc:stable, OK?
next prev parent reply other threads:[~2020-08-11 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 7:59 [PATCH] mm/vunmap: Add cond_resched() in vunmap_pmd_range Aneesh Kumar K.V
2020-08-11 4:46 ` Andrew Morton [this message]
2020-08-11 8:47 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810214655.a3f82fc8ccd671a392164a09@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=harish@linux.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).