From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B81C433DF for ; Wed, 12 Aug 2020 01:36:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BBCCF2076C for ; Wed, 12 Aug 2020 01:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NDLhdAsk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBCCF2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 681128D0074; Tue, 11 Aug 2020 21:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 630B38D0001; Tue, 11 Aug 2020 21:36:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547208D0074; Tue, 11 Aug 2020 21:36:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 3FD758D0001 for ; Tue, 11 Aug 2020 21:36:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0543540C7 for ; Wed, 12 Aug 2020 01:36:58 +0000 (UTC) X-FDA: 77140202916.25.hot53_5a1148726fe7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id C9F141804E3A0 for ; Wed, 12 Aug 2020 01:36:57 +0000 (UTC) X-HE-Tag: hot53_5a1148726fe7 X-Filterd-Recvd-Size: 2986 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 01:36:57 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 613632054F; Wed, 12 Aug 2020 01:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597196216; bh=aMk+83/RLXXJVbImsAOvHmckd9FREpD+PPEko6ylxsM=; h=Date:From:To:Subject:In-Reply-To:From; b=NDLhdAskB4G7c0ltOQFc+ZUeNTRqimIUo5vuyKpaM69DgEuhDqgSaT0RZI95rZLw2 b5rg4Vf8FNbUsYStsecwkJEotnZXsWGZ+5IGCgVvTGOJ3XPl4hfG0/VTSBbL3BGYdC gtq/CbPOGE/ZSnGg5wnjSPNtlXPl92aDFeCx1V+8= Date: Tue, 11 Aug 2020 18:36:56 -0700 From: Andrew Morton To: akpm@linux-foundation.org, andreyknvl@google.com, dvyukov@google.com, elver@google.com, glider@google.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, ndesaulniers@google.com, torvalds@linux-foundation.org Subject: [patch 126/165] kcov: unconditionally add -fno-stack-protector to compiler options Message-ID: <20200812013656.qG5s2DjpF%akpm@linux-foundation.org> In-Reply-To: <20200811182949.e12ae9a472e3b5e27e16ad6c@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: C9F141804E3A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Marco Elver Subject: kcov: unconditionally add -fno-stack-protector to compiler options Unconditionally add -fno-stack-protector to KCOV's compiler options, as all supported compilers support the option. This saves a compiler invocation to determine if the option is supported. Because Clang does not support -fno-conserve-stack, and -fno-stack-protector was wrapped in the same cc-option, we were missing -fno-stack-protector with Clang. Unconditionally adding this option fixes this for Clang. Link: http://lkml.kernel.org/r/20200615184302.7591-1-elver@google.com Signed-off-by: Marco Elver Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Reviewed-by: Andrey Konovalov Cc: Dmitry Vyukov Cc: Alexander Potapenko Signed-off-by: Andrew Morton --- kernel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/Makefile~kcov-unconditionally-add-fno-stack-protector-to-compiler-options +++ a/kernel/Makefile @@ -36,7 +36,7 @@ KCOV_INSTRUMENT_stacktrace.o := n KCOV_INSTRUMENT_kcov.o := n KASAN_SANITIZE_kcov.o := n KCSAN_SANITIZE_kcov.o := n -CFLAGS_kcov.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector) +CFLAGS_kcov.o := $(call cc-option, -fno-conserve-stack) -fno-stack-protector # cond_syscall is currently not LTO compatible CFLAGS_sys_ni.o = $(DISABLE_LTO) _