From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BCDC433E0 for ; Wed, 12 Aug 2020 18:41:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DF3A2078B for ; Wed, 12 Aug 2020 18:41:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="euwku213" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DF3A2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A309F8D0002; Wed, 12 Aug 2020 14:41:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E10C8D0001; Wed, 12 Aug 2020 14:41:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F99E8D0002; Wed, 12 Aug 2020 14:41:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 7872D8D0001 for ; Wed, 12 Aug 2020 14:41:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E057B181AEF1D for ; Wed, 12 Aug 2020 18:41:48 +0000 (UTC) X-FDA: 77142785496.14.fan99_0f12cbc26fed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B8BD318229835 for ; Wed, 12 Aug 2020 18:41:48 +0000 (UTC) X-HE-Tag: fan99_0f12cbc26fed X-Filterd-Recvd-Size: 2036 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 18:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=taALEl31n5pTztHIbf/jZMP7iDzxzM3DQW82GaErDBQ=; b=euwku213OpLsyXgAERqwinY3t7 s3M2Ug9PDRCZ8vLJk2Ay61Kqp5UDNeOIw+tWzy446x6vFHEP2mXaHxQx/f8kvQvJLe4AQ3JAdvSG0 wMiiN/d53QVUvaGfwVzA/OxG0OlPan7dK8wJWG+34pR8oP5DUDlU4FJeX9zt985SUnxykNGZ1U8nH TQvX7QAtTFjouxe3jR1qJ6t08oY8ikxAHIwUqaJDpxar/NEh1yezDxPtaVNhtuLs2GgGUxUyg06CW W7ewZ9wtUw5R7hM61+o+bAWpLH3hUTVZDbDVMEyKvzgv970oHv30l/LRY1xSA42Y4vJbBGnHR7yJg JetfcUwA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5vh0-00022v-MG; Wed, 12 Aug 2020 18:41:42 +0000 Date: Wed, 12 Aug 2020 19:41:41 +0100 From: Matthew Wilcox To: Andy Shevchenko Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v1] mm/dmapool.c: Replace open-coded list_first_entry() Message-ID: <20200812184141.GC17456@casper.infradead.org> References: <20200812153059.51089-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200812153059.51089-1-andriy.shevchenko@linux.intel.com> X-Rspamd-Queue-Id: B8BD318229835 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 12, 2020 at 06:30:59PM +0300, Andy Shevchenko wrote: > while (!list_empty(&pool->page_list)) { > struct dma_page *page; > - page = list_entry(pool->page_list.next, > - struct dma_page, page_list); > + > + page = list_first_entry(&pool->page_list, struct dma_page, page_list); Eh, I'd rather see this as: struct dma_page *page = list_first_entry(&pool->page_list, struct dma_page, page_list);