From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A074C433E1 for ; Thu, 13 Aug 2020 11:26:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 320B020791 for ; Thu, 13 Aug 2020 11:26:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320B020791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB44F6B0002; Thu, 13 Aug 2020 07:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A65336B0003; Thu, 13 Aug 2020 07:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97A2D6B000D; Thu, 13 Aug 2020 07:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 8324F6B0002 for ; Thu, 13 Aug 2020 07:26:51 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3E3DF180AD807 for ; Thu, 13 Aug 2020 11:26:51 +0000 (UTC) X-FDA: 77145318222.07.seed42_2513c6126ff3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 186A61803F9B3 for ; Thu, 13 Aug 2020 11:26:51 +0000 (UTC) X-HE-Tag: seed42_2513c6126ff3 X-Filterd-Recvd-Size: 2578 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Aug 2020 11:26:50 +0000 (UTC) IronPort-SDR: JsjneaBFkQwvWSpP2S12LlVWnXhXcSLKxepvXrjdvhh5lzndCHIZ302wW9zsn8eR/9CbOy2Vwf UlPb6NtrhAJw== X-IronPort-AV: E=McAfee;i="6000,8403,9711"; a="155324348" X-IronPort-AV: E=Sophos;i="5.76,308,1592895600"; d="scan'208";a="155324348" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2020 04:26:49 -0700 IronPort-SDR: GLIL0XC0qRwjI+5Y9/yAH79KWc6c3ppuajNpNrm58xVpZ905YW8KagVkNr0UoXukNGhL8saVwZ emDO3zl7+X+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,308,1592895600"; d="scan'208";a="325384520" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 13 Aug 2020 04:26:48 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k6B6z-008QO1-SE; Thu, 13 Aug 2020 14:09:33 +0300 Date: Thu, 13 Aug 2020 14:09:33 +0300 From: Andy Shevchenko To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v1] mm/dmapool.c: Replace open-coded list_first_entry() Message-ID: <20200813110933.GM1891694@smile.fi.intel.com> References: <20200812153059.51089-1-andriy.shevchenko@linux.intel.com> <20200812184141.GC17456@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200812184141.GC17456@casper.infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 186A61803F9B3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 12, 2020 at 07:41:41PM +0100, Matthew Wilcox wrote: > On Wed, Aug 12, 2020 at 06:30:59PM +0300, Andy Shevchenko wrote: > > while (!list_empty(&pool->page_list)) { > > struct dma_page *page; > > - page = list_entry(pool->page_list.next, > > - struct dma_page, page_list); > > + > > + page = list_first_entry(&pool->page_list, struct dma_page, page_list); > > Eh, I'd rather see this as: > > struct dma_page *page = list_first_entry(&pool->page_list, > struct dma_page, page_list); On the second thought we may convert the entire loop to use list_for_each_entry_safe() since there is no locking in between, we should be fine. -- With Best Regards, Andy Shevchenko