From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B36C433DF for ; Wed, 19 Aug 2020 20:54:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5CC7E21734 for ; Wed, 19 Aug 2020 20:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sp9yPMfK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CC7E21734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B41158D005B; Wed, 19 Aug 2020 16:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF4B8D0057; Wed, 19 Aug 2020 16:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E1078D005B; Wed, 19 Aug 2020 16:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 858C68D0057 for ; Wed, 19 Aug 2020 16:54:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3CCF8362C for ; Wed, 19 Aug 2020 20:54:21 +0000 (UTC) X-FDA: 77168521122.24.night56_360c3052702b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 1270E1A4A5 for ; Wed, 19 Aug 2020 20:54:21 +0000 (UTC) X-HE-Tag: night56_360c3052702b X-Filterd-Recvd-Size: 4644 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 20:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597870460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HLbcN3vXZ9Y2wTIy0CakALnZtq7aqQjupWdhJYMTw6g=; b=Sp9yPMfKm0Uo3wrF9NvLpAq8sqMAGWfDvr32tlW/wg1GUdBHUsQzRqv+sxdJyIXUsJKj/l g7IXSea8pQYkXD3fA5Txb676dCeyCH0SuNiXZYTLEcu6EAxEFjobxLM6O8x1d1kEWgHMgA xMchL9XH8mKN70Y/sxT/JAPjUBDs8c8= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-522-V8jGsWurMxyAWp5-Ws1hmA-1; Wed, 19 Aug 2020 16:54:18 -0400 X-MC-Unique: V8jGsWurMxyAWp5-Ws1hmA-1 Received: by mail-pl1-f198.google.com with SMTP id q22so68946pls.13 for ; Wed, 19 Aug 2020 13:54:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HLbcN3vXZ9Y2wTIy0CakALnZtq7aqQjupWdhJYMTw6g=; b=ncCb4zV6amkmJN+GySy2nXPrnvGbAL5Nh90hLSKxMw7OqwPiR1ZrYO5fExh1S+qUha wZIjlCUtxUpnOAof1txgZXU16nBz4+/p98GIv/TJjPb+ISiveTkEzR9//8z6dKJqif0p o2viQp2hsgdcV+XRHPr54gN8HqaJbXJk2JuvWt7DFzT+h0s5Nex1BNnhPA9oSC4zTJwH oUUuxQePje+VU8jqZ++nQhn6zRFkvnqTYIL6802aTEBB2nmm6oPUbTlMrHM2SYO5drFU sfQ/sKGo1VQSCtD0N4AnOpRnqlw/4zJwlMLklFCLf43I/pgUnyUewbw42MH7OUUS8OV1 PHUw== X-Gm-Message-State: AOAM531uJbG1i55KR1ShgwiycBYMDb4KH9RIisNIFIQWUScGwbfybZmg sqYk3aSTy45wl8zIGIT0qb8q52ibwhtulY/fprE6yHGkIrSNyUFqGlTk2mRf0GH2pySO4nuAQwt hiZpJLsXr1ek= X-Received: by 2002:a63:151c:: with SMTP id v28mr143596pgl.357.1597870457463; Wed, 19 Aug 2020 13:54:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywvQDnMQvNa8P+hthAlsp+uhweYcJmFYGtS1L+2LN00W9j3zaiphk/gpzyn1Jn6xogphyN9g== X-Received: by 2002:a63:151c:: with SMTP id v28mr143580pgl.357.1597870457205; Wed, 19 Aug 2020 13:54:17 -0700 (PDT) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id nu14sm3825940pjb.19.2020.08.19.13.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 13:54:16 -0700 (PDT) Date: Thu, 20 Aug 2020 04:54:05 +0800 From: Gao Xiang To: Rafael Aquini Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Carlos Maiolino , Eric Sandeen , "Huang, Ying" , stable Subject: Re: [PATCH] mm, THP, swap: fix allocating cluster for swapfile by mistake Message-ID: <20200819205405.GB26216@xiangao.remote.csb> References: <20200819195613.24269-1-hsiangkao@redhat.com> <20200819130506.eea076dd618644cd7ff875b6@linux-foundation.org> <20200819204405.GB2096425@optiplex-lnx> MIME-Version: 1.0 In-Reply-To: <20200819204405.GB2096425@optiplex-lnx> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hsiangkao@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 1270E1A4A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Rafael, On Wed, Aug 19, 2020 at 04:44:05PM -0400, Rafael Aquini wrote: > On Wed, Aug 19, 2020 at 01:05:06PM -0700, Andrew Morton wrote: > > On Thu, 20 Aug 2020 03:56:13 +0800 Gao Xiang wrote: > > > > > SWP_FS doesn't mean the device is file-backed swap device, > > > which just means each writeback request should go through fs > > > by DIO. Or it'll just use extents added by .swap_activate(), > > > but it also works as file-backed swap device. > > > > This is very hard to understand :( > > > > I'll work with Gao to rephrase that message. Sorry! Sorry about that :( I just finished the test and went through the related swap code and finally saw this so I think it wouldn't work entirely for the current swap code... and Sorry about my limited English. Kindly feel free to repost the patch with rephrased commit message. Anyway, I've done this task :) Thanks, Gao Xiang