From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBFBC433E1 for ; Thu, 20 Aug 2020 02:15:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54F162078B for ; Thu, 20 Aug 2020 02:15:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54F162078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBFC68D0009; Wed, 19 Aug 2020 22:15:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6FAA8D0003; Wed, 19 Aug 2020 22:15:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B847F8D0009; Wed, 19 Aug 2020 22:15:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 9EE228D0003 for ; Wed, 19 Aug 2020 22:15:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5FE7C180AD802 for ; Thu, 20 Aug 2020 02:15:40 +0000 (UTC) X-FDA: 77169330840.14.roll97_0c108f32702c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 1DB6318229835 for ; Thu, 20 Aug 2020 02:15:40 +0000 (UTC) X-HE-Tag: roll97_0c108f32702c X-Filterd-Recvd-Size: 2037 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 02:15:38 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0U6GzjvK_1597889732; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U6GzjvK_1597889732) by smtp.aliyun-inc.com(127.0.0.1); Thu, 20 Aug 2020 10:15:32 +0800 Date: Thu, 20 Aug 2020 10:15:31 +0800 From: Wei Yang To: Andrew Morton Cc: Wei Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink() Message-ID: <20200820021531.GA51743@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200809232057.23477-1-richard.weiyang@linux.alibaba.com> <20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819131210.dc5c045a626d1bf4475214d1@linux-foundation.org> X-Rspamd-Queue-Id: 1DB6318229835 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.024018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 01:12:10PM -0700, Andrew Morton wrote: >On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang wrote: > >> __vma_unlink_common() and __vma_unlink() are counterparts. Since there is > >I assume you meant "__vma_link()" here? > Oops, my fault. You are right. Do you prefer a v2, or you would like to fix it online? >> not function named __vma_unlink(), let's rename it to __vma_unlink() to >> make the code more self-explain and easy for audience to understand. >> >> Otherwise we may expect there are several variants of vma_unlink and >> __vma_unlink_common() is used by them. -- Wei Yang Help you, Help me