From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0051C433E3 for ; Thu, 20 Aug 2020 21:15:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 96ED12076E for ; Thu, 20 Aug 2020 21:15:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MxXD+oKZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96ED12076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A0E06B0022; Thu, 20 Aug 2020 17:15:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12E598D0005; Thu, 20 Aug 2020 17:15:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0DFD6B0025; Thu, 20 Aug 2020 17:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id D4BB06B0022 for ; Thu, 20 Aug 2020 17:15:22 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 93519181AEF07 for ; Thu, 20 Aug 2020 21:15:22 +0000 (UTC) X-FDA: 77172202884.09.week43_4b0ca0527033 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 6526E180AD817 for ; Thu, 20 Aug 2020 21:15:22 +0000 (UTC) X-HE-Tag: week43_4b0ca0527033 X-Filterd-Recvd-Size: 5619 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 21:15:21 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id m34so1724710pgl.11 for ; Thu, 20 Aug 2020 14:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3orOYLwVm7pbL0JPg5qyxGq8OLLOoHc4FMSri6VFgAY=; b=MxXD+oKZZSZqoRbLpKhnQmHA2iCndMw0X4oByYVvCkC/ZFePZOTWcW1dB8kiyDVSEE ljNIfxCh9rDy1VAffXVL0+MEwhU1QDmVzfYSv6SRZEMgqQXnUPILoXhMV3S4ap72/HhV 7z//pmiAQiNPqu4ribdzAzVwJLdikyAL6NGzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3orOYLwVm7pbL0JPg5qyxGq8OLLOoHc4FMSri6VFgAY=; b=uDjNwGBdd3c3W85dq6F8zfJ9M2SUIWx2SIWLC9iOJBH4NH8SK6hCXb8BqeELAQczFE JZtTPH2VNRsOfzUTfs9fM4JxOtLRS/KAfj0SnlFbr3HSqXuQoraCulk1gB8sRkaVmLdI bBJbkks5q51P/MUC2Vf9ukF63gunQOJrJP1BlV6vnSa/gm67yR4tLrtX+QHOA+vc72df goqN8kQFiHljiEQZIDXCrK81I+3mQgbdTB2qBfwxFxkmmnKDwzVCXHTIXzOwXEuofyjD /0HuSLZUQd92YqcyMx4Dy0BAJ/1qmGz77zM/syrRgK7aBjce1To4ixw0UvKARgOk1ynl DF7Q== X-Gm-Message-State: AOAM533PdFAAA180H9XJdgHiCXpI1vg4b+XzpbuPXVVbb0inEpgC6dX9 8lgSB/uwvWKyi3AhHA0goxxfuw== X-Google-Smtp-Source: ABdhPJwxPPaRqUJSuHzaKNwJ6nAQly/YsVqNBZTv6tsh11T5Q3uws4QC3ryocoXsBIiwF+WUT9kp3g== X-Received: by 2002:aa7:8b18:: with SMTP id f24mr457033pfd.301.1597958120903; Thu, 20 Aug 2020 14:15:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r25sm3399218pgv.88.2020.08.20.14.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 14:15:20 -0700 (PDT) Date: Thu, 20 Aug 2020 14:15:19 -0700 From: Kees Cook To: Oleg Nesterov Cc: Sumit Semwal , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Michal Hocko , Colin Cross , Alexey Gladkov , Matthew Wilcox , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , Michal =?iso-8859-1?Q?Koutn=FD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Thomas Hellstrom , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Rik van Riel , Mel Gorman , Tang Chen , Robin Holt , Shaohua Li , Sasha Levin , Johannes Weiner , Minchan Kim Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory Message-ID: <202008201414.9E7F4F9D0C@keescook> References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200820160014.GF4546@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200820160014.GF4546@redhat.com> X-Rspamd-Queue-Id: 6526E180AD817 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 20, 2020 at 06:00:14PM +0200, Oleg Nesterov wrote: > On 08/19, Sumit Semwal wrote: > > > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2484,7 +2484,7 @@ static inline int vma_adjust(struct vm_area_struct *vma, unsigned long start, > > extern struct vm_area_struct *vma_merge(struct mm_struct *, > > struct vm_area_struct *prev, unsigned long addr, unsigned long end, > > unsigned long vm_flags, struct anon_vma *, struct file *, pgoff_t, > > - struct mempolicy *, struct vm_userfaultfd_ctx); > > + struct mempolicy *, struct vm_userfaultfd_ctx, const char __user *); > > It seems that you forgot to update the callers in fs/userfaultfd.c ? (I recommend including "make allmodconfig && make" in your test workflow.) -- Kees Cook