From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8BEC433DF for ; Thu, 20 Aug 2020 15:47:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5ED0E208DB for ; Thu, 20 Aug 2020 15:47:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RNwX2CMT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ED0E208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC8D38D0030; Thu, 20 Aug 2020 11:47:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C78508D0001; Thu, 20 Aug 2020 11:47:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19CA8D0030; Thu, 20 Aug 2020 11:47:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 9C6428D0001 for ; Thu, 20 Aug 2020 11:47:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4D91B180AD806 for ; Thu, 20 Aug 2020 15:47:02 +0000 (UTC) X-FDA: 77171375484.20.rat50_4e0189127031 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id BF8D8180C07A3 for ; Thu, 20 Aug 2020 15:47:01 +0000 (UTC) X-HE-Tag: rat50_4e0189127031 X-Filterd-Recvd-Size: 4916 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 15:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597938419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6o5mhrwXHxNSJkQwMFrTxsRC2YKqD7rp14cUFxrLnak=; b=RNwX2CMTlZuWQpr+gNEQ2pKluRSCwsTuCzFjaUMUz5+I+BYu33NcPKXYLyDmMpbmy5FasM iXNduhoIDbEmRmZVYvx3wo5mxS/aMtHQOuk9/wiDrKKXyk7g1k1khgp4/6XcytdldY/hrw ICK8YUK6HW72ApiQlQXXe6mYjGciH20= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-ZPqYkYFANciMJ2BjktTNcw-1; Thu, 20 Aug 2020 11:46:57 -0400 X-MC-Unique: ZPqYkYFANciMJ2BjktTNcw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61256186A582; Thu, 20 Aug 2020 15:46:51 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.73]) by smtp.corp.redhat.com (Postfix) with SMTP id EC2241B47B; Thu, 20 Aug 2020 15:46:29 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 20 Aug 2020 17:46:51 +0200 (CEST) Date: Thu, 20 Aug 2020 17:46:28 +0200 From: Oleg Nesterov To: Matthew Wilcox Cc: Sumit Semwal , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Kees Cook , Michal Hocko , Colin Cross , Alexey Gladkov , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , Michal =?iso-8859-1?Q?Koutn=FD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Thomas Hellstrom , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Rik van Riel , Mel Gorman , Tang Chen , Robin Holt , Shaohua Li , Sasha Levin , Johannes Weiner , Minchan Kim Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory Message-ID: <20200820154628.GE4546@redhat.com> References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200819150251.GD17456@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819150251.GD17456@casper.infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Queue-Id: BF8D8180C07A3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/19, Matthew Wilcox wrote: > > You can significantly reduce the size of this patch by doing this instead: > > union { > struct { > struct rb_node rb; > unsigned long rb_subtree_last; > } shared; > const char __user *anon_name; > }; Agreed, And to me "unsigned long anon_name" looks better, vma_anon_name() should return "unsigned long" too. The only thing which reads this string is seq_print_vma_name() and it has typecast anon_name anyway. But I won't insist, this is cosmetic and subjective. Oleg.