From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63ACC433E1 for ; Thu, 20 Aug 2020 16:30:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0B21207BB for ; Thu, 20 Aug 2020 16:30:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0B21207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 342748D0037; Thu, 20 Aug 2020 12:30:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2778D0001; Thu, 20 Aug 2020 12:30:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2438D0037; Thu, 20 Aug 2020 12:30:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 05AA08D0001 for ; Thu, 20 Aug 2020 12:30:03 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9F7C48248047 for ; Thu, 20 Aug 2020 16:30:02 +0000 (UTC) X-FDA: 77171483844.06.geese20_4b0324227032 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 433271004BCC1 for ; Thu, 20 Aug 2020 16:30:02 +0000 (UTC) X-HE-Tag: geese20_4b0324227032 X-Filterd-Recvd-Size: 3340 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 16:30:01 +0000 (UTC) Received: from ip5f5af70b.dynamic.kabel-deutschland.de ([95.90.247.11] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k8nRR-00052d-F1; Thu, 20 Aug 2020 16:29:29 +0000 Date: Thu, 20 Aug 2020 18:29:27 +0200 From: Christian Brauner To: Michal Hocko Cc: Suren Baghdasaryan , "Eric W. Biederman" , Tetsuo Handa , Tim Murray , mingo@kernel.org, Peter Zijlstra , Thomas Gleixner , esyr@redhat.com, christian@kellner.me, areber@redhat.com, Shakeel Butt , cyphar@cyphar.com, Oleg Nesterov , adobriyan@gmail.com, Andrew Morton , gladkov.alexey@gmail.com, Michel Lespinasse , daniel.m.jordan@oracle.com, avagin@gmail.com, bernd.edlinger@hotmail.de, John Johansen , laoar.shao@gmail.com, Minchan Kim , kernel-team , LKML , linux-fsdevel@vger.kernel.org, linux-mm Subject: Re: [PATCH 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary Message-ID: <20200820162927.s275qsr4lkwizutu@wittgenstein> References: <87lfi9xz7y.fsf@x220.int.ebiederm.org> <87d03lxysr.fsf@x220.int.ebiederm.org> <20200820132631.GK5033@dhcp22.suse.cz> <20200820133454.ch24kewh42ax4ebl@wittgenstein> <20200820140054.fdkbotd4tgfrqpe6@wittgenstein> <637ab0e7-e686-0c94-753b-b97d24bb8232@i-love.sakura.ne.jp> <87k0xtv0d4.fsf@x220.int.ebiederm.org> <20200820162645.GP5033@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200820162645.GP5033@dhcp22.suse.cz> X-Rspamd-Queue-Id: 433271004BCC1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 20, 2020 at 06:26:45PM +0200, Michal Hocko wrote: > On Thu 20-08-20 08:56:53, Suren Baghdasaryan wrote: > [...] > > Catching up on the discussion which was going on while I was asleep... > > So it sounds like there is a consensus that oom_adj should be moved to > > mm_struct rather than trying to synchronize it among tasks sharing mm. > > That sounds reasonable to me too. Michal answered all the earlier > > questions about this patch, so I won't be reiterating them, thanks > > Michal. If any questions are still lingering about the original patch > > I'll be glad to answer them. > > I think it still makes some sense to go with a simpler (aka less tricky) > solution which would be your original patch with an incremental fix for > vfork and the proper ordering (http://lkml.kernel.org/r/20200820124109.GI5033@dhcp22.suse.cz) > and then make a more complex shift to mm struct on top of that. The > former will be less tricky to backport to stable IMHO. /me nods Christian