From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBC5C433DF for ; Thu, 20 Aug 2020 22:15:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2DA62075E for ; Thu, 20 Aug 2020 22:15:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ANe7rdMh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2DA62075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 695A66B002E; Thu, 20 Aug 2020 18:15:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6446B6B00AD; Thu, 20 Aug 2020 18:15:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517738D0003; Thu, 20 Aug 2020 18:15:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 3B5106B002E for ; Thu, 20 Aug 2020 18:15:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 00341181AEF0B for ; Thu, 20 Aug 2020 22:15:52 +0000 (UTC) X-FDA: 77172355386.02.wing63_3903c1827034 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id D21A210097AA0 for ; Thu, 20 Aug 2020 22:15:52 +0000 (UTC) X-HE-Tag: wing63_3903c1827034 X-Filterd-Recvd-Size: 6276 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 22:15:52 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id v12so3802831ljc.10 for ; Thu, 20 Aug 2020 15:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oFuEpXo370XLPeaDSlEl+scvWT0cx0+/Z4tOLjeNnw0=; b=ANe7rdMhzp8jUWEeWu1acKSmhP/OFbOTcM0q368NNq20EzlFEtMCRvtoNRr6smVJuZ Qz67aOMaFzqTeEz8gtLi14j6EOU6BAA9m/8JKiMJDvVsP2eNU6AVGzh/XEarD3nY2+ri i7caSuZ4nBXxPXPf2/cDRtGu4arqQbjE27L5nBum0YBODEvvfutBktJJkbRPmc0DOrQ1 c64OAERL3Z9LF2okUU+u+K3yVEaalRaeKtZrMTJ9ABUBZwSAWyK7rIb4X0soxHYYTkfH dsLwOkpmvdta/v73eVdltilKTyzq7lbdEEjySCO7GquXdMTl7WOVC69U2kx44gR2fu7X 8dVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oFuEpXo370XLPeaDSlEl+scvWT0cx0+/Z4tOLjeNnw0=; b=b/FLIwwCbDftV1PAG7H3nItYcz7Hqa/dvZzsQvjy8xnUmnwnHLO6qBsuwLlkECuUI2 P2vC3dHu4bOqbKoRwM2oJKBeskBW7em5sMxG45bS+53gkUSDBF/txp8E6PGxQ+rPaXIl EXA+kKTNCvDIoy6JJWMjZ7a5gxbQT2ZZT06AunD0JquDdKFzADBxGjvVJGdy1stZrEKP LJNbboT2L/EtRy9nBWiqlQOzHbAH5yp1IfxuzfniUGvjkoCH6ZZy1N7KTCezdRIBUveh xP7HmWHVw+WT93yFmcef/VAqqc4jIV3oZtf2CExmni/xvX7/2IUoj/unpzmBMn796ApV 9CtQ== X-Gm-Message-State: AOAM530JkE0d3G8LXiWE2khfEocwvbhVPjFxOir9U+EK/bTe7vsLohBC nF8En9SXOweI3HJV9eNMcvs= X-Google-Smtp-Source: ABdhPJwKU3TtCBbBD7E9CRpj6jl1Ow1Za6I/o/RakY52XIT76r+zlQ9tVNlOQUXr4kPBEj87mfSW9w== X-Received: by 2002:a05:651c:221:: with SMTP id z1mr59804ljn.52.1597961750851; Thu, 20 Aug 2020 15:15:50 -0700 (PDT) Received: from grain.localdomain ([5.18.103.226]) by smtp.gmail.com with ESMTPSA id n29sm776556lfi.9.2020.08.20.15.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 15:15:49 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 5EC9D1A0078; Fri, 21 Aug 2020 01:15:49 +0300 (MSK) Date: Fri, 21 Aug 2020 01:15:49 +0300 From: Cyrill Gorcunov To: Colin Cross Cc: Sumit Semwal , Andrew Morton , Linux-MM , lkml , Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Kees Cook , Michal Hocko , Alexey Gladkov , Matthew Wilcox , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , Michal =?iso-8859-1?Q?Koutn=FD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Thomas Hellstrom , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , Oleg Nesterov , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Rik van Riel , Mel Gorman , Tang Chen , Robin Holt , Shaohua Li , Sasha Levin , Johannes Weiner , Minchan Kim Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory Message-ID: <20200820221549.GV2074@grain> References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200820214003.GR2074@grain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Rspamd-Queue-Id: D21A210097AA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 20, 2020 at 02:45:27PM -0700, Colin Cross wrote: > > > > Guys, could you please enlighen me, I don't understand -- we pass some > > random user-space pointer and save it in vm_area_struct then in procfs > > we treat it as "string" and print out? What prevents me to put some crap > > here then unmap this pointer the kernel will cause page fault in procfs > > output (in best scenario)? > > This is the same pattern used for /proc/pid/cmdline. > acccess_remote_vm handles addresses in unmapped pages, it will return > 0 if no bytes were readable. Yes, been in this part of code too long ago, managed to forget. You know I'm wondering do we really need a human readable names here? Maybe it would be more convenient to keep say u64 number instead? This would eliminate need to access VM at all. From user space point of view there should be no difference how to recognize such VMAs (by name or by some ID). Or there some need for string solely?