From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72FBFC433DF for ; Mon, 24 Aug 2020 01:43:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34A07206BE for ; Mon, 24 Aug 2020 01:43:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mdYKCDjS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A07206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC0798D0001; Sun, 23 Aug 2020 21:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C95726B0006; Sun, 23 Aug 2020 21:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B866C8D0001; Sun, 23 Aug 2020 21:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 9F2076B0005 for ; Sun, 23 Aug 2020 21:43:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5DFEE3629 for ; Mon, 24 Aug 2020 01:43:16 +0000 (UTC) X-FDA: 77183764392.28.tiger93_440d9942704f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 251F96C3B for ; Mon, 24 Aug 2020 01:43:16 +0000 (UTC) X-HE-Tag: tiger93_440d9942704f X-Filterd-Recvd-Size: 7262 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 01:43:15 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id y11so3098995qvl.4 for ; Sun, 23 Aug 2020 18:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HSviFJCpw83eFSkNKYg4Z96JUEkZ+NJpzpGZSayRsVY=; b=mdYKCDjSJOo0w9iUtvWFLnZo4dThfXKQOE79XjBlZGhS9Yhb59h4bgpCJKYbmb0KpC ZnpBv0cLQD2wnGAhAtvyQ8esk9E4XNNrNvuqANorsAUFQ5e7K269RywYqXtEccZerWBc 5MgYCNe6ScwA7TGzCsg58X+eDnMPLDUOTIJ6SmQbt/VvwRzvLVLegbJzw4JWaAGUtg+D pf0LQaiG6FiVeFPbLpojQapNpkx4hTQIUi0tOtzEYYG2N3l2CbtodKeZnPXlJoKvea0k 1ziwRt+fdfpXnAKOsFxP51ZlRCe8gKDoVlvM8+0QzuJEZDI0ooNoG+hbnRCCtJF973Zy 4haQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HSviFJCpw83eFSkNKYg4Z96JUEkZ+NJpzpGZSayRsVY=; b=TuZAPuL29n1IQW59fv5sHTcRmPPuBLnjuEwisJ2MLwCJuuYdG7TZUhHVzRWpbhABqR Oo35gjKzeDz69fk9oKn5kdltWtU3VH+K2YQm/Q9JxJ4FANhioj9VkBwuQ7PsonQoqKEQ Nx+TAHxTHjFu6LqFzfg4Yw0+7vk1Ih5JIDFNOEP/WIRX+eV20myyTpPWhHpHmUtLnbME ufaznt/K+AlHdCeA2hcsg2n57aj2g5Bai3nlM94W8/iwzLLaT7XybKCNPnktk/zQqj/E JqQ7fE21Dj5TDxU//T84PDt9PIZRm2rtbzaDRV2euKg7LyzqjTvAlBIQOXpukvJq/w3a Vt/w== X-Gm-Message-State: AOAM530FvY/LWiwAtg8jMUchG9NUO6nNV4urHAm9WbKECIb0I3lyo+3U +ApOqzztDlDA3lCwUX59dbOM7mwteQQeTFbg X-Google-Smtp-Source: ABdhPJylHP/+mTa0EKoUj5q0EHUCdw80GAeRz4zllvLRrzIE8MOJOYgkA8J5131Z5T09DJZlWmQ8+Q== X-Received: by 2002:ad4:4984:: with SMTP id t4mr3030693qvx.110.1598233395243; Sun, 23 Aug 2020 18:43:15 -0700 (PDT) Received: from localhost.localdomain ([50.236.19.102]) by smtp.gmail.com with ESMTPSA id t8sm10205236qtc.50.2020.08.23.18.43.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Aug 2020 18:43:14 -0700 (PDT) From: Yafang Shao To: david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com, willy@infradead.org, mhocko@kernel.org, akpm@linux-foundation.org Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Yafang Shao Subject: [PATCH v6 1/2] mm: Add become_kswapd and restore_kswapd Date: Mon, 24 Aug 2020 09:42:33 +0800 Message-Id: <20200824014234.7109-2-laoar.shao@gmail.com> X-Mailer: git-send-email 2.17.2 (Apple Git-113) In-Reply-To: <20200824014234.7109-1-laoar.shao@gmail.com> References: <20200824014234.7109-1-laoar.shao@gmail.com> X-Rspamd-Queue-Id: 251F96C3B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Since XFS needs to pretend to be kswapd in some of its worker threads, create methods to save & restore kswapd state. Don't bother restoring kswapd state in kswapd -- the only time we reach this code is when we're exiting and the task_struct is about to be destroyed anyway. Cc: Dave Chinner Cc: Christoph Hellwig Cc: Darrick J. Wong Cc: Matthew Wilcox Acked-by: Michal Hocko Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Yafang Shao --- fs/xfs/libxfs/xfs_btree.c | 14 ++++++++------ include/linux/sched/mm.h | 23 +++++++++++++++++++++++ mm/vmscan.c | 16 +--------------- 3 files changed, 32 insertions(+), 21 deletions(-) diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c index 2d25bab68764..a04a44238aab 100644 --- a/fs/xfs/libxfs/xfs_btree.c +++ b/fs/xfs/libxfs/xfs_btree.c @@ -2813,8 +2813,9 @@ xfs_btree_split_worker( { struct xfs_btree_split_args *args = container_of(work, struct xfs_btree_split_args, work); + bool is_kswapd = args->kswapd; unsigned long pflags; - unsigned long new_pflags = PF_MEMALLOC_NOFS; + int memalloc_nofs; /* * we are in a transaction context here, but may also be doing work @@ -2822,16 +2823,17 @@ xfs_btree_split_worker( * temporarily to ensure that we don't block waiting for memory reclaim * in any way. */ - if (args->kswapd) - new_pflags |= PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD; - - current_set_flags_nested(&pflags, new_pflags); + if (is_kswapd) + pflags = become_kswapd(); + memalloc_nofs = memalloc_nofs_save(); args->result = __xfs_btree_split(args->cur, args->level, args->ptrp, args->key, args->curp, args->stat); complete(args->done); - current_restore_flags_nested(&pflags, new_pflags); + memalloc_nofs_restore(memalloc_nofs); + if (is_kswapd) + restore_kswapd(pflags); } /* diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h index f889e332912f..b38fdcb977a4 100644 --- a/include/linux/sched/mm.h +++ b/include/linux/sched/mm.h @@ -303,6 +303,29 @@ static inline void memalloc_nocma_restore(unsigned int flags) } #endif +/* + * Tell the memory management code that this thread is working on behalf + * of background memory reclaim (like kswapd). That means that it will + * get access to memory reserves should it need to allocate memory in + * order to make forward progress. With this great power comes great + * responsibility to not exhaust those reserves. + */ +#define KSWAPD_PF_FLAGS (PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD) + +static inline unsigned long become_kswapd(void) +{ + unsigned long flags = current->flags & KSWAPD_PF_FLAGS; + + current->flags |= KSWAPD_PF_FLAGS; + + return flags; +} + +static inline void restore_kswapd(unsigned long flags) +{ + current->flags &= ~(flags ^ KSWAPD_PF_FLAGS); +} + #ifdef CONFIG_MEMCG /** * memalloc_use_memcg - Starts the remote memcg charging scope. diff --git a/mm/vmscan.c b/mm/vmscan.c index 99e1796eb833..3a2615bfde35 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3859,19 +3859,7 @@ static int kswapd(void *p) if (!cpumask_empty(cpumask)) set_cpus_allowed_ptr(tsk, cpumask); - /* - * Tell the memory management that we're a "memory allocator", - * and that if we need more memory we should get access to it - * regardless (see "__alloc_pages()"). "kswapd" should - * never get caught in the normal page freeing logic. - * - * (Kswapd normally doesn't need memory anyway, but sometimes - * you need a small amount of memory in order to be able to - * page out something else, and this flag essentially protects - * us from recursively trying to free more memory as we're - * trying to free the first piece of memory in the first place). - */ - tsk->flags |= PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD; + become_kswapd(); set_freezable(); WRITE_ONCE(pgdat->kswapd_order, 0); @@ -3921,8 +3909,6 @@ static int kswapd(void *p) goto kswapd_try_sleep; } - tsk->flags &= ~(PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD); - return 0; } -- 2.18.1