From: Chris Down <chris@chrisdown.name>
To: Xunlei Pang <xlpang@linux.alibaba.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: memcg: Fix memcg reclaim soft lockup
Date: Wed, 26 Aug 2020 19:17:25 +0100 [thread overview]
Message-ID: <20200826181725.GA893402@chrisdown.name> (raw)
In-Reply-To: <20200826141044.GA831829@chrisdown.name>
Chris Down writes:
>Xunlei Pang writes:
>>Add cond_resched() at the upper shrink_node_memcgs() to solve this
>>issue, and any other possible issue like meomry.min protection.
>
>I understand the general intent of the patch, but could you clarify
>your concern around memory protection?
Oh, I see, your concern is just preemption in general rather than a fixing
anything for the memory protection side. In which case, go for it, but I agree
with Michael that it would be nice to send v3 with a clarifying comment.
Acked-by: Chris Down <chris@chrisdown.name>
next prev parent reply other threads:[~2020-08-26 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 13:47 [PATCH v2] mm: memcg: Fix memcg reclaim soft lockup Xunlei Pang
2020-08-26 14:10 ` Chris Down
2020-08-26 18:17 ` Chris Down [this message]
2020-08-26 15:05 ` Michal Hocko
2020-08-26 16:43 ` Johannes Weiner
2020-08-26 17:29 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826181725.GA893402@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).