From: Matthew Wilcox <willy@infradead.org>
To: hejinyang <hejinyang@loongson.cn>
Cc: Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Tiezhu Yang <yangtiezhu@loongson.cn>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: Loongson: Fix complie errors without CONFIG_SMP
Date: Thu, 27 Aug 2020 04:12:16 +0100 [thread overview]
Message-ID: <20200827031216.GB14765@casper.infradead.org> (raw)
In-Reply-To: <5394f030-104c-f191-e581-4f1ed23a85a6@loongson.cn>
On Thu, Aug 27, 2020 at 10:31:33AM +0800, hejinyang wrote:
>
>
> On 08/26/2020 09:01 PM, Matthew Wilcox wrote:
> > On Wed, Aug 26, 2020 at 08:53:27PM +0800, Jinyang He wrote:
> > > +++ b/arch/mips/include/asm/mach-loongson64/topology.h
> > > @@ -4,7 +4,11 @@
> > > #ifdef CONFIG_NUMA
> > > +#ifdef CONFIG_SMP
> > > #define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2)
> > > +#else
> > > +#define cpu_to_node(cpu) 0
> > > +#endif
> > Are you saying you've enabled NUMA without enabling SMP? Does that make
> > sense?
>
> NUMA option normally work with more than two nodes, though Loongson64 use it
> default after patch 6fbde6b492dfc761ad60a68fb2cb32b1eb05b786. Loongson64(3A)'s
> each node consists of 4 cpus while it only has 4 cpus. In other words, it has
> only one node while open NUMA. I'm confused it if NUMA deponds on SMP.
>
> I'll try fix it with unabling NUMA and SMP later.
mips:
config NUMA
bool "NUMA Support"
depends on SYS_SUPPORTS_NUMA
x86:
config NUMA
bool "NUMA Memory Allocation and Scheduler Support"
depends on SMP
If you had a good reason for enabling NUMA without enabling SMP (CPU-less
memory nodes?), that'd be an interesting discussion to have. Since your
hardware seems to have SMP by default, I'd suggest just adding the missing
'depends'.
prev parent reply other threads:[~2020-08-27 3:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 12:53 [PATCH] MIPS: Loongson: Fix complie errors without CONFIG_SMP Jinyang He
2020-08-26 13:01 ` Matthew Wilcox
2020-08-27 2:31 ` hejinyang
2020-08-27 3:12 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827031216.GB14765@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chenhc@lemote.com \
--cc=hejinyang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).