From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8302BC433E1 for ; Thu, 27 Aug 2020 11:13:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4082C22CBB for ; Thu, 27 Aug 2020 11:13:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4082C22CBB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA9C86B000C; Thu, 27 Aug 2020 07:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3398900002; Thu, 27 Aug 2020 07:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20546B000E; Thu, 27 Aug 2020 07:13:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id A97406B000C for ; Thu, 27 Aug 2020 07:13:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 63100181AEF0B for ; Thu, 27 Aug 2020 11:13:51 +0000 (UTC) X-FDA: 77196088662.13.screw90_410db932706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 34BE518140B60 for ; Thu, 27 Aug 2020 11:13:51 +0000 (UTC) X-HE-Tag: screw90_410db932706c X-Filterd-Recvd-Size: 2733 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 11:13:50 +0000 (UTC) Received: from gaia (unknown [46.69.195.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 867CA22CB3; Thu, 27 Aug 2020 11:13:47 +0000 (UTC) Date: Thu, 27 Aug 2020 12:13:45 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/35] kasan, arm64: Enable TBI EL1 Message-ID: <20200827111344.GK29264@gaia> References: <518da1e5169a4e343caa3c37feed5ad551b77a34.1597425745.git.andreyknvl@google.com> <20200827104033.GF29264@gaia> <9c53dfaa-119e-b12e-1a91-1f67f4aef503@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c53dfaa-119e-b12e-1a91-1f67f4aef503@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 34BE518140B60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 12:05:55PM +0100, Vincenzo Frascino wrote: > On 8/27/20 11:40 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:08PM +0200, Andrey Konovalov wrote: > >> diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > >> index 152d74f2cc9c..6880ddaa5144 100644 > >> --- a/arch/arm64/mm/proc.S > >> +++ b/arch/arm64/mm/proc.S > >> @@ -38,7 +38,7 @@ > >> /* PTWs cacheable, inner/outer WBWA */ > >> #define TCR_CACHE_FLAGS TCR_IRGN_WBWA | TCR_ORGN_WBWA > >> > >> -#ifdef CONFIG_KASAN_SW_TAGS > >> +#if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > >> #define TCR_KASAN_FLAGS TCR_TBI1 > >> #else > >> #define TCR_KASAN_FLAGS 0 > > > > I prefer to turn TBI1 on only if MTE is present. So on top of the v8 > > user series, just do this in __cpu_setup. > > Not sure I understand... Enabling TBI1 only if MTE is present would break > KASAN_SW_TAGS which is based on TBI1 but not on MTE. You keep the KASAN_SW_TAGS as above but for HW_TAGS, only set TBI1 later in __cpu_setup(). -- Catalin