From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F181C433DF for ; Thu, 27 Aug 2020 14:02:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44DF22087D for ; Thu, 27 Aug 2020 14:02:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="xS4StaPp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44DF22087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94B2A8E000B; Thu, 27 Aug 2020 10:02:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FB588E0006; Thu, 27 Aug 2020 10:02:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813218E000B; Thu, 27 Aug 2020 10:02:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 6BA0E8E0006 for ; Thu, 27 Aug 2020 10:02:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EFE4752C3 for ; Thu, 27 Aug 2020 14:02:00 +0000 (UTC) X-FDA: 77196512400.22.hall98_1e0d2982706d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6821918038E78 for ; Thu, 27 Aug 2020 14:01:58 +0000 (UTC) X-HE-Tag: hall98_1e0d2982706d X-Filterd-Recvd-Size: 4563 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 14:01:48 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id b3so3396372qtg.13 for ; Thu, 27 Aug 2020 07:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dfRzlPwQNyPtrYJ/iS+qwie4ofTE9hR5y2kv8hIuyaA=; b=xS4StaPpTGC1Pj9KQLMY1y4Hh+DxvuykLCRhRCCR2ks3lS4BDPvs2wAKBG5COFaV+Z 5a4iKQJRjfMzWvoEDRU+GIkjB6GHtWfHpJ/EnWEgGdhu+csIuY3GLUOjg1fPvtbeBDw/ 9kG7Tk4zkmcZbKeDMfK5TOyej+CKEs9zTCMzbx1iaTd9NO7CLzwhQUxNiMJes9ogin7K p8BpEdUk6FDEm+vs2kKUij8P4AbrVwzMbgEd5ySyVT+NMACU39HJ5japIJqtRQdyteCb vS/QIbWLJazcKT9ZK+bYjwJJ0I2rU8smS8FdNM9Y4fMY0myIX8+sxThkICielkbfW1wJ gykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dfRzlPwQNyPtrYJ/iS+qwie4ofTE9hR5y2kv8hIuyaA=; b=OLZvLMoq4K5s7fHybEUAMFyM7+FEf65S5CJXUAseimVvqreOcF7ZQqSg82Z2Vv8foD uhXMbxjJtzbEDtMV8lpezyvleUf0PPwTGAXwFn7Z5vUE78eesa137+f8likqnZTPgwNJ ewk3YUZ8RUf/wRhL8VavYRYnwjqVESLRNztsbmxX77kE00Prebh4ax2cDFIjjiuxIWtO 6thqwLmffcewX80HrMwtwN0CBUtvMMb5crxcFu5VjJz/R6za5Ydnl549Llac10O0DH4Y 4isNcSd1Fp4LFiK7QMMOUUBkeV00zV7+76zLrxmUCcz/6WLsl/XjvjqgmjNNeUguvu/Y nU1g== X-Gm-Message-State: AOAM530FsD0S5EG5wjljBrIWwG1i68QgEVilO901mDbbcjB+DJnCVEaN rOvbVbYw06hl0CQMGspjqHHOSg== X-Google-Smtp-Source: ABdhPJwHe/G+MpJjSZgeTDwatG8hgzZOb57B0FlRcGdq6AtF9uloUz2i4857L2RN01YtIeqdvZ25sg== X-Received: by 2002:ac8:4c86:: with SMTP id j6mr19065010qtv.65.1598536906039; Thu, 27 Aug 2020 07:01:46 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:412a]) by smtp.gmail.com with ESMTPSA id o47sm1860852qtk.19.2020.08.27.07.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 07:01:45 -0700 (PDT) Date: Thu, 27 Aug 2020 10:00:28 -0400 From: Johannes Weiner To: Xunlei Pang Cc: Michal Hocko , Andrew Morton , Vladimir Davydov , Chris Down , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: memcg: Fix memcg reclaim soft lockup Message-ID: <20200827140028.GA1002856@cmpxchg.org> References: <1598495549-67324-1-git-send-email-xlpang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598495549-67324-1-git-send-email-xlpang@linux.alibaba.com> X-Rspamd-Queue-Id: 6821918038E78 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 10:32:29AM +0800, Xunlei Pang wrote: > We've met softlockup with "CONFIG_PREEMPT_NONE=y", when > the target memcg doesn't have any reclaimable memory. > > It can be easily reproduced as below: > watchdog: BUG: soft lockup - CPU#0 stuck for 111s![memcg_test:2204] > CPU: 0 PID: 2204 Comm: memcg_test Not tainted 5.9.0-rc2+ #12 > Call Trace: > shrink_lruvec+0x49f/0x640 > shrink_node+0x2a6/0x6f0 > do_try_to_free_pages+0xe9/0x3e0 > try_to_free_mem_cgroup_pages+0xef/0x1f0 > try_charge+0x2c1/0x750 > mem_cgroup_charge+0xd7/0x240 > __add_to_page_cache_locked+0x2fd/0x370 > add_to_page_cache_lru+0x4a/0xc0 > pagecache_get_page+0x10b/0x2f0 > filemap_fault+0x661/0xad0 > ext4_filemap_fault+0x2c/0x40 > __do_fault+0x4d/0xf9 > handle_mm_fault+0x1080/0x1790 > > It only happens on our 1-vcpu instances, because there's no chance > for oom reaper to run to reclaim the to-be-killed process. > > Add a cond_resched() at the upper shrink_node_memcgs() to solve this > issue, this will mean that we will get a scheduling point for each > memcg in the reclaimed hierarchy without any dependency on the > reclaimable memory in that memcg thus making it more predictable. > > Acked-by: Chris Down > Acked-by: Michal Hocko > Suggested-by: Michal Hocko > Signed-off-by: Xunlei Pang Acked-by: Johannes Weiner