From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEF2DC433E6 for ; Mon, 31 Aug 2020 16:52:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E4EC20707 for ; Mon, 31 Aug 2020 16:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E4EC20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A7336B0003; Mon, 31 Aug 2020 12:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857EF6B0037; Mon, 31 Aug 2020 12:52:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76E006B0055; Mon, 31 Aug 2020 12:52:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F2D46B0003 for ; Mon, 31 Aug 2020 12:52:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 12513181AEF0B for ; Mon, 31 Aug 2020 16:52:28 +0000 (UTC) X-FDA: 77211457176.18.watch05_500f06a27091 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id D11DC100EC665 for ; Mon, 31 Aug 2020 16:52:27 +0000 (UTC) X-HE-Tag: watch05_500f06a27091 X-Filterd-Recvd-Size: 2360 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 16:52:26 +0000 (UTC) IronPort-SDR: DErL/HPV4UkMMX2fKJnT5lNdh5pUnhQbu+Z9ibU9xYagjB9D/sEAW8ZuNjlr6HgPP1JBhlcRYL O41UQLUdEEfw== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="175066388" X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="175066388" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 09:52:23 -0700 IronPort-SDR: W2+IE27pQLjMaQbC7PYHRurSpcOOAvO8WlyMWDfsKP/zKKBAXOlnNvxMwl67pea2uOmir0Z/fg 4h0UqW2z0TEg== X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="476800745" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 09:52:23 -0700 Date: Mon, 31 Aug 2020 09:52:22 -0700 From: Ira Weiny To: John Hubbard Cc: Andrew Morton , Alexander Viro , Christoph Hellwig , Ilya Dryomov , Jens Axboe , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v3 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast() Message-ID: <20200831165222.GD1422350@iweiny-DESK2.sc.intel.com> References: <20200831071439.1014766-1-jhubbard@nvidia.com> <20200831071439.1014766-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831071439.1014766-4-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: D11DC100EC665 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 31, 2020 at 12:14:39AM -0700, John Hubbard wrote: > @@ -1113,8 +1113,8 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) > } else { > if (is_bvec) > ret = __bio_iov_bvec_add_pages(bio, iter); > - else > - ret = __bio_iov_iter_get_pages(bio, iter); > + else > + ret = __bio_iov_iter_get_pages(bio, iter); Why the white space change? Ira