From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
Christoph Hellwig <hch@lst.de>, Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] mm/migrate: preserve soft dirty in remove_migration_pte()
Date: Tue, 1 Sep 2020 07:20:25 +0200 [thread overview]
Message-ID: <20200901052025.GB27876@lst.de> (raw)
In-Reply-To: <20200831212222.22409-3-rcampbell@nvidia.com>
On Mon, Aug 31, 2020 at 02:22:22PM -0700, Ralph Campbell wrote:
> The code to remove a migration PTE and replace it with a device private
> PTE was not copying the soft dirty bit from the migration entry.
> This could lead to page contents not being marked dirty when faulting
> the page back from device private memory.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-09-01 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 21:22 [PATCH 0/2] mm/migrate: preserve soft dirty in remove_migration_pte() Ralph Campbell
2020-08-31 21:22 ` [PATCH 1/2] mm/migrate: remove unnecessary is_zone_device_page() check Ralph Campbell
2020-09-01 5:19 ` Christoph Hellwig
2020-08-31 21:22 ` [PATCH 2/2] mm/migrate: preserve soft dirty in remove_migration_pte() Ralph Campbell
2020-09-01 5:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901052025.GB27876@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bharata@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).