From: Michal Hocko <mhocko@suse.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm/memory_hotplug: drain per-cpu pages again during memory offline
Date: Wed, 2 Sep 2020 16:10:57 +0200 [thread overview]
Message-ID: <20200902141057.GK4617@dhcp22.suse.cz> (raw)
In-Reply-To: <20200902140116.GI4617@dhcp22.suse.cz>
On Wed 02-09-20 16:01:17, Michal Hocko wrote:
> [Cc Mel and Vlastimil - I am still rummaging]
>
> On Tue 01-09-20 08:46:15, Pavel Tatashin wrote:
> > There is a race during page offline that can lead to infinite loop:
> > a page never ends up on a buddy list and __offline_pages() keeps
> > retrying infinitely or until a termination signal is received.
> >
> > Thread#1 - a new process:
> >
> > load_elf_binary
> > begin_new_exec
> > exec_mmap
> > mmput
> > exit_mmap
> > tlb_finish_mmu
> > tlb_flush_mmu
> > release_pages
> > free_unref_page_list
> > free_unref_page_prepare
> > set_pcppage_migratetype(page, migratetype);
> > // Set page->index migration type below MIGRATE_PCPTYPES
> >
> > Thread#2 - hot-removes memory
> > __offline_pages
> > start_isolate_page_range
> > set_migratetype_isolate
> > set_pageblock_migratetype(page, MIGRATE_ISOLATE);
> > Set migration type to MIGRATE_ISOLATE-> set
> > drain_all_pages(zone);
> > // drain per-cpu page lists to buddy allocator.
> >
> > Thread#1 - continue
> > free_unref_page_commit
> > migratetype = get_pcppage_migratetype(page);
> > // get old migration type
> > list_add(&page->lru, &pcp->lists[migratetype]);
> > // add new page to already drained pcp list
> >
> > Thread#2
> > Never drains pcp again, and therefore gets stuck in the loop.
> >
> > The fix is to try to drain per-cpu lists again after
> > check_pages_isolated_cb() fails.
Still trying to wrap my head around this but I think this is not a
proper fix. It should be the page isolation to make sure no races are
possible with the page freeing path.
> > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> > Cc: stable@vger.kernel.org
> > ---
> > mm/memory_hotplug.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > index e9d5ab5d3ca0..d6d54922bfce 100644
> > --- a/mm/memory_hotplug.c
> > +++ b/mm/memory_hotplug.c
> > @@ -1575,6 +1575,15 @@ static int __ref __offline_pages(unsigned long start_pfn,
> > /* check again */
> > ret = walk_system_ram_range(start_pfn, end_pfn - start_pfn,
> > NULL, check_pages_isolated_cb);
> > + /*
> > + * per-cpu pages are drained in start_isolate_page_range, but if
> > + * there are still pages that are not free, make sure that we
> > + * drain again, because when we isolated range we might
> > + * have raced with another thread that was adding pages to
> > + * pcp list.
> > + */
> > + if (ret)
> > + drain_all_pages(zone);
> > } while (ret);
> >
> > /* Ok, all of our target is isolated.
> > --
> > 2.25.1
> >
>
> --
> Michal Hocko
> SUSE Labs
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-09-02 14:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:46 [PATCH] mm/memory_hotplug: drain per-cpu pages again during memory offline Pavel Tatashin
2020-09-01 18:37 ` David Rientjes
2020-09-02 14:01 ` Michal Hocko
2020-09-02 14:10 ` Michal Hocko [this message]
2020-09-02 14:31 ` Pavel Tatashin
2020-09-02 14:49 ` Vlastimil Babka
2020-09-02 14:08 ` Michal Hocko
2020-09-02 14:26 ` Pavel Tatashin
2020-09-02 14:55 ` Vlastimil Babka
2020-09-02 15:13 ` Michal Hocko
2020-09-02 15:40 ` Pavel Tatashin
2020-09-02 17:51 ` Vlastimil Babka
2020-09-03 6:38 ` Michal Hocko
2020-09-03 18:20 ` David Hildenbrand
2020-09-03 18:23 ` Pavel Tatashin
2020-09-03 18:31 ` David Hildenbrand
2020-09-04 7:02 ` Michal Hocko
2020-09-04 14:25 ` Pavel Tatashin
2020-09-07 7:26 ` Michal Hocko
2020-09-04 6:32 ` Vlastimil Babka
2020-09-03 7:07 ` Michal Hocko
2020-09-03 13:43 ` Pavel Tatashin
2020-09-03 13:50 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902141057.GK4617@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).