From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CB2C433E7 for ; Wed, 2 Sep 2020 16:20:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 564A6208B3 for ; Wed, 2 Sep 2020 16:20:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hmO5GLct" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 564A6208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D710D6B0055; Wed, 2 Sep 2020 12:20:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2269900009; Wed, 2 Sep 2020 12:20:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5EBA6B005D; Wed, 2 Sep 2020 12:20:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id B20FC6B0055 for ; Wed, 2 Sep 2020 12:20:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6DAAC1F10 for ; Wed, 2 Sep 2020 16:20:17 +0000 (UTC) X-FDA: 77218633674.02.cook06_0f137d8270a2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 3ED3B10097AA0 for ; Wed, 2 Sep 2020 16:20:17 +0000 (UTC) X-HE-Tag: cook06_0f137d8270a2 X-Filterd-Recvd-Size: 5865 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 16:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599063616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I3XppnnrIephKMf+c97CJaQhGKT7XO5RfPDNT2gEhBw=; b=hmO5GLctVVj4WgIOyoohwMGQWhK0FVq5oF4b7pWL/koUfGFDMs1Ct9BWVmdecT1ovjlijA du3UIu2o2sQzUOMe9Sap51KRDQ+nS14WWoYFZ0AVXkLAds90WSg/Mhacgud15FKH5Fv4gN 25ftkKfrKp/ZAFmoWsvXESnVNN9My9o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-2MV1gUebNPOKGqCVe8X-ug-1; Wed, 02 Sep 2020 12:20:14 -0400 X-MC-Unique: 2MV1gUebNPOKGqCVe8X-ug-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D717518B9EC0; Wed, 2 Sep 2020 16:20:11 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F8C77E306; Wed, 2 Sep 2020 16:20:08 +0000 (UTC) Date: Wed, 2 Sep 2020 12:20:07 -0400 From: Mike Snitzer To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, martin.petersen@oracle.com, Hans de Goede , Song Liu , Richard Weinberger , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Minchan Kim , dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-mm@kvack.org, drbd-dev@tron.linbit.com, cgroups@vger.kernel.org Subject: Re: [PATCH 06/14] block: lift setting the readahead size into the block layer Message-ID: <20200902162007.GB5513@redhat.com> References: <20200726150333.305527-1-hch@lst.de> <20200726150333.305527-7-hch@lst.de> <20200826220737.GA25613@redhat.com> <20200902151144.GA1738@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902151144.GA1738@lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Queue-Id: 3ED3B10097AA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 02 2020 at 11:11am -0400, Christoph Hellwig wrote: > On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer wrote: > > On Sun, Jul 26 2020 at 11:03am -0400, > > Christoph Hellwig wrote: > > > > > Drivers shouldn't really mess with the readahead size, as that is a VM > > > concept. Instead set it based on the optimal I/O size by lifting the > > > algorithm from the md driver when registering the disk. Also set > > > bdi->io_pages there as well by applying the same scheme based on > > > max_sectors. > > > > > > Signed-off-by: Christoph Hellwig > > > --- > > > block/blk-settings.c | 5 ++--- > > > block/blk-sysfs.c | 1 - > > > block/genhd.c | 13 +++++++++++-- > > > drivers/block/aoe/aoeblk.c | 2 -- > > > drivers/block/drbd/drbd_nl.c | 12 +----------- > > > drivers/md/bcache/super.c | 4 ---- > > > drivers/md/dm-table.c | 3 --- > > > drivers/md/raid0.c | 16 ---------------- > > > drivers/md/raid10.c | 24 +----------------------- > > > drivers/md/raid5.c | 13 +------------ > > > 10 files changed, 16 insertions(+), 77 deletions(-) > > > > > > In general these changes need a solid audit relative to stacking > > drivers. That is, the limits stacking methods (blk_stack_limits) > > vs lower level allocation methods (__device_add_disk). > > > > You optimized for lowlevel __device_add_disk establishing the bdi's > > ra_pages and io_pages. That is at the beginning of disk allocation, > > well before any build up of stacking driver's queue_io_opt() -- which > > was previously done in disk_stack_limits or driver specific methods > > (e.g. dm_table_set_restrictions) that are called _after_ all the limits > > stacking occurs. > > > > By inverting the setting of the bdi's ra_pages and io_pages to be done > > so early in __device_add_disk it'll break properly setting these values > > for at least DM afaict. > > ra_pages never got inherited by stacking drivers, check it by modifying > it on an underlying device and then creating a trivial dm or md one. Sure, not saying that it did. But if the goal is to set ra_pages based on io_opt then to do that correctly on stacking drivers it must be done in terms of limits stacking right? Or at least done at a location that is after the limits stacking has occurred? So should DM just open-code setting ra_pages like it did for io_pages? Because setting ra_pages in __device_add_disk() is way too early for DM -- given it uses device_add_disk_no_queue_reg via add_disk_no_queue_reg at DM device creation (before stacking all underlying devices' limits). > And I think that is a good thing - in general we shouldn't really mess > with this thing from drivers if we can avoid it. I've kept the legacy > aoe and md parity raid cases, out of which the first looks pretty weird > and the md one at least remotely sensible. I don't want drivers, like DM, to have to worry about these. So I agree with that goal ;) > ->io_pages is still inherited in disk_stack_limits, just like before > so no change either. I'm missing where, but I only looked closer at this 06/14 patch. In it I see io_pages is no longer adjusted in disk_stack_limits(). Mike