Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-mm@kvack.org, Song Liu <songliubraving@fb.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Qian Cai <cai@lca.pw>
Subject: [PATCH 0/3] Fix read-only THP for non-tmpfs filesystems
Date: Thu,  3 Sep 2020 19:30:26 +0100
Message-ID: <20200903183029.14930-1-willy@infradead.org> (raw)

As described more verbosely in the [3/3] changelog, we can
inadvertently put an order-0 page in the page cache which
occupies 512 consecutive entries.  Users are running into
this if they enable the READ_ONLY_THP_FOR_FS config option;
see https://bugzilla.kernel.org/show_bug.cgi?id=206569
and Qian Cai has also reported it here:
https://lore.kernel.org/lkml/20200616013309.GB815@lca.pw/

This is a rather intrusive way of fixing the problem, but has the
advantage that I've actually been testing it with the THP patches,
which means that it sees far more use than it does upstream -- indeed,
Song has been entirely unable to reproduce it.  It also has the advantage
that it removes a few patches from my gargantuan backlog of THP patches.

Matthew Wilcox (Oracle) (3):
  XArray: Add xa_get_order
  XArray: Add xas_split
  mm/filemap: Fix storing to a THP shadow entry

 Documentation/core-api/xarray.rst |  16 +--
 include/linux/xarray.h            |  22 ++++
 lib/test_xarray.c                 |  62 ++++++++++
 lib/xarray.c                      | 196 ++++++++++++++++++++++++++++--
 mm/filemap.c                      |  42 +++++--
 5 files changed, 311 insertions(+), 27 deletions(-)

-- 
2.28.0



             reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 18:30 Matthew Wilcox (Oracle) [this message]
2020-09-03 18:30 ` [PATCH 1/3] XArray: Add xa_get_order Matthew Wilcox (Oracle)
2020-09-03 18:30 ` [PATCH 2/3] XArray: Add xas_split Matthew Wilcox (Oracle)
2020-09-03 18:30 ` [PATCH 3/3] mm/filemap: Fix storing to a THP shadow entry Matthew Wilcox (Oracle)
2020-09-04 17:23 ` [PATCH 0/3] Fix read-only THP for non-tmpfs filesystems Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903183029.14930-1-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git