From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB26C433E2 for ; Fri, 4 Sep 2020 23:36:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 014542087C for ; Fri, 4 Sep 2020 23:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jGeZTtca" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 014542087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93E536B0074; Fri, 4 Sep 2020 19:36:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EDCB6B0075; Fri, 4 Sep 2020 19:36:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8307C6B0078; Fri, 4 Sep 2020 19:36:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 6DA386B0074 for ; Fri, 4 Sep 2020 19:36:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 342598248047 for ; Fri, 4 Sep 2020 23:36:00 +0000 (UTC) X-FDA: 77226989280.06.oil53_4e0408a270b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 09C681003BAA0 for ; Fri, 4 Sep 2020 23:36:00 +0000 (UTC) X-HE-Tag: oil53_4e0408a270b6 X-Filterd-Recvd-Size: 2871 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 23:35:59 +0000 (UTC) Received: from localhost.localdomain (c-71-198-47-131.hsd1.ca.comcast.net [71.198.47.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D9FF2084D; Fri, 4 Sep 2020 23:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599262558; bh=qsweA78ZdcuiRQlthDWALdt7wAoXJpkxDQexeRQbdic=; h=Date:From:To:Subject:In-Reply-To:From; b=jGeZTtca/by5CTh8ULcQu2FvG0NLuTNQQRnAmNwj0iYjL6tCVdhX47QuFbj6SQ/Q1 yJRLaoNnfCg9WBMdIPUL/ey57IpJNiCWs9X9t9Lyl+HBG8wBy6xD3hDVi4o//CM2GN b39sgH03qF37X2+dJMAzfqqbFtTKnql9OGc1cgtc= Date: Fri, 04 Sep 2020 16:35:58 -0700 From: Andrew Morton To: akpm@linux-foundation.org, alistair@popple.id.au, jglisse@redhat.com, jhubbard@nvidia.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, peterx@redhat.com, rcampbell@nvidia.com, torvalds@linux-foundation.org Subject: [patch 12/19] mm/migrate: fixup setting UFFD_WP flag Message-ID: <20200904233558.ivUQZ2xpI%akpm@linux-foundation.org> In-Reply-To: <20200904163454.4db0e6ce0c4584d2653678a3@linux-foundation.org> User-Agent: s-nail v14.8.16 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 09C681003BAA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =46rom: Alistair Popple Subject: mm/migrate: fixup setting UFFD_WP flag Commit f45ec5ff16a75 ("userfaultfd: wp: support swap and page migration") introduced support for tracking the uffd wp bit during page migration.=20 However the non-swap PTE variant was used to set the flag for zone device private pages which are a type of swap page. This leads to corruption of the swap offset if the original PTE has the uffd_wp flag set. Link: https://lkml.kernel.org/r/20200825064232.10023-1-alistair@popple.id.au Fixes: f45ec5ff16a75 ("userfaultfd: wp: support swap and page migration") Signed-off-by: Alistair Popple Reviewed-by: Peter Xu Cc: J=C3=A9r=C3=B4me Glisse Cc: John Hubbard Cc: Ralph Campbell Signed-off-by: Andrew Morton --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/migrate.c~mm-migrate-fixup-setting-uffd_wp-flag +++ a/mm/migrate.c @@ -251,7 +251,7 @@ static bool remove_migration_pte(struct entry =3D make_device_private_entry(new, pte_write(pte)); pte =3D swp_entry_to_pte(entry); if (pte_swp_uffd_wp(*pvmw.pte)) - pte =3D pte_mkuffd_wp(pte); + pte =3D pte_swp_mkuffd_wp(pte); } } =20 _