From: Mike Rapoport <rppt@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Michal Simek <monstr@monstr.eu>, Christoph Hellwig <hch@lst.de>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] <linux/page-isolation.h>: provide stubs for MEMORY_ISOLATION not set (for Microblaze)
Date: Mon, 7 Sep 2020 10:05:11 +0300 [thread overview]
Message-ID: <20200907070511.GN424181@linux.ibm.com> (raw)
In-Reply-To: <1f6b42e6-b6b5-40e3-92b4-77bd610d3e49@infradead.org>
Hi Randy,
On Sun, Sep 06, 2020 at 12:33:08PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors in Microblaze when CONFIG_MEMORY_ISOLATION is not
> set/enabled by adding stubs for 3 missing functions.
I've tried to follow Kconfig dependencies to see how could we have both
CONTIG_ALLOC=y and CONFIG_MEMORY_ISOLATION=n and I could not find how
was this possible.
We have
config CONTIG_ALLOC
def_bool (MEMORY_ISOLATION && COMPACTION) || CMA
and
config CMA
bool "Contiguous Memory Allocator"
depends on MMU
select MIGRATION
select MEMORY_ISOLATION
and alloc_contig_range() is hidden behind '#ifdef CONFIG_CONTIG_ALLOC'
In any rate, I think the better fix would be to update Kconfig
dependencies rather than add stubs for these functions.
> Fixes these build errors:
>
> gcc-9.3.0-nolibc/microblaze-linux/bin/microblaze-linux-ld: mm/page_alloc.o: in function `alloc_contig_range':
> (.text+0xa0c0): undefined reference to `start_isolate_page_range'
> gcc-9.3.0-nolibc/microblaze-linux/bin/microblaze-linux-ld: (.text+0xa2bc): undefined reference to `test_pages_isolated'
> gcc-9.3.0-nolibc/microblaze-linux/bin/microblaze-linux-ld: (.text+0xa378): undefined reference to `undo_isolate_page_range'
>
> Fixes: 0815f3d81d76 ("mm: page_isolation: MIGRATE_CMA isolation functions added") # v3.10
> Fixes: b023f46813cd ("memory-hotplug: skip HWPoisoned page when offlining pages") # v3.10
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michal Nazarewicz <mina86@mina86.com>
> Cc: Wen Congyang <wency@cn.fujitsu.com>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Cc: linux-mm@kvack.org
> ---
> include/linux/page-isolation.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> --- linux-next-20200903.orig/include/linux/page-isolation.h
> +++ linux-next-20200903/include/linux/page-isolation.h
> @@ -28,6 +28,22 @@ static inline bool is_migrate_isolate(in
> {
> return false;
> }
> +static inline int test_pages_isolated(unsigned long start_pfn,
> + unsigned long end_pfn, int isol_flags)
> +{
> + return 0;
> +}
> +static inline int
> +start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
> + unsigned migratetype, int flags)
> +{
> + return 0;
> +}
> +static inline void
> +undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
> + unsigned migratetype)
> +{
> +}
> #endif
>
> #define MEMORY_OFFLINE 0x1
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-09-07 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 19:33 [PATCH] <linux/page-isolation.h>: provide stubs for MEMORY_ISOLATION not set (for Microblaze) Randy Dunlap
2020-09-07 7:05 ` Mike Rapoport [this message]
2020-09-07 22:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907070511.GN424181@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mina86@mina86.com \
--cc=monstr@monstr.eu \
--cc=rdunlap@infradead.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).