From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21183C433E2 for ; Tue, 8 Sep 2020 17:58:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DFAC2074B for ; Tue, 8 Sep 2020 17:58:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TgU0nbUg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DFAC2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77C676B005A; Tue, 8 Sep 2020 13:58:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72CD26B005C; Tue, 8 Sep 2020 13:58:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 669796B005D; Tue, 8 Sep 2020 13:58:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 5112F6B005A for ; Tue, 8 Sep 2020 13:58:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 18B988248047 for ; Tue, 8 Sep 2020 17:58:18 +0000 (UTC) X-FDA: 77240653476.03.face98_3c095ad270d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id D4E9528A4E8 for ; Tue, 8 Sep 2020 17:58:17 +0000 (UTC) X-HE-Tag: face98_3c095ad270d6 X-Filterd-Recvd-Size: 2971 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Sep 2020 17:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DO6W80RdfG9P9Z4fc9rbaY/MdeJfPrgZXo3Rg960r0c=; b=TgU0nbUgP8phE3d+0e2QoGBHwD feFtPdBAtdEUbNiMqPm/NVSd+CE+MM4/wZoKFaY/3kaNkarsSzAEcimpK4Do9wIl8maTrW1Du71hI zYZecYMsVtVLhzfUUyza+suNgTeHebQ9tS/p/NnPhV46tR8hb5sGj6vP7cQQJ7v3VRm4/NQZE4o0z MiknYyoeDKA44fWsJis4tcZnyeeGSMzSmr+aBA6WwkfNnxOv3vVdchd4A4Mtx9/JxBIMB6UqHe9uN IEoyAnN5V/5vTSoXA58/nEkv6c8+IFyOe0p9BxadW9g/kkC1i3MHF8x/igPFUkuECYrfkt6caA2j2 Js+InoZA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFhsh-0006Ym-Vv; Tue, 08 Sep 2020 17:58:12 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9ED99307590; Tue, 8 Sep 2020 19:58:08 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8601D24C37E82; Tue, 8 Sep 2020 19:58:08 +0200 (CEST) Date: Tue, 8 Sep 2020 19:58:08 +0200 From: peterz@infradead.org To: Qian Cai Cc: mark.rutland@arm.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH -next] fork: silence a false postive warning in __mmdrop Message-ID: <20200908175808.GX1362448@hirez.programming.kicks-ass.net> References: <20200604150344.1796-1-cai@lca.pw> <20200722100637.GR119549@hirez.programming.kicks-ass.net> <20200722131900.GA4041@lca.pw> <20200722134406.GN10769@hirez.programming.kicks-ass.net> <20200908165043.GD5147@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908165043.GD5147@lca.pw> X-Rspamd-Queue-Id: D4E9528A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002458, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 08, 2020 at 12:50:44PM -0400, Qian Cai wrote: > > No, you're talking nonsense. We must not free @mm when > > 'current->active_mm == mm', never. > > Yes, you are right. It still trigger this below on powerpc with today's > linux-next by fuzzing for a while (saw a few times on recent linux-next before > as well but so far mostly reproducible on powerpc here). Any idea? If you can reliably reproduce this, the next thing is to trace mm_count and figure out where it goes side-ways. I suppose we're looking for an 'extra' decrement. Mark tried this for a while but gave up because he couldn't reliably reproduce.