From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9DDC433E2 for ; Fri, 11 Sep 2020 02:14:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E06212076D for ; Fri, 11 Sep 2020 02:14:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HSLAHaSF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E06212076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D03E6B0082; Thu, 10 Sep 2020 22:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 080436B0083; Thu, 10 Sep 2020 22:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED82D6B0088; Thu, 10 Sep 2020 22:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id D7BBC6B0082 for ; Thu, 10 Sep 2020 22:14:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A284B3629 for ; Fri, 11 Sep 2020 02:14:01 +0000 (UTC) X-FDA: 77249160282.14.slave96_0b129b0270eb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 755F618229818 for ; Fri, 11 Sep 2020 02:14:01 +0000 (UTC) X-HE-Tag: slave96_0b129b0270eb X-Filterd-Recvd-Size: 10249 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Sep 2020 02:14:00 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id n133so8377776qkn.11 for ; Thu, 10 Sep 2020 19:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kTjTaXAUIVG8guSvTTK04JJOQ81rc1LCw3u4xDMGxj0=; b=HSLAHaSF6WD0O2qzm1kcGX8wYB6EpDFGZYZyE+uIoIGMjEaOm+AfqPntVhu1Yp7MKw bDAidoRuytdteg3WzBoq+i9bMEefdqkbX1S1CAjHYo992tYg1Fi0+s5mKG4SjEybfOOg L4agXR7HBlXbpAmcoD8huNC8XihE+6Px1mWw/UZvIAek1HBNZGu8CNX9T3Wqk0i1Nere FLh0Tva566RAwkKf+VK8B7wKLdiePZQstH+HlfrgjXmFeZ9EBUorU/g3U32g5ABoN0Jg bNvA3aAuvy4rxNkKXmErdDvZVTodMmh92BOc8jUWu0YXg0jowpPhyIjH131sPUEZWNn3 FMUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kTjTaXAUIVG8guSvTTK04JJOQ81rc1LCw3u4xDMGxj0=; b=ZPJ7e4AhBv1pkob6gTBlcm8FoPh+BBurHhpeRQid8JVr623uBGHmgh4O1d9CoFJRBX qjrZdPgl/qWKrm87EqutBtbwVdSApEcJ27K4egCI4ZU3x1y3u0TCprUeSzeKK5qDq5k1 V3dbEmt++Er4XxT/DWDF7Ky8m6LMBO7evLF1V0oKwm9cft7FzTIy1hPEZnC7sqwGGMWQ uK+WvCvay9Rr3HEWdZmGennl2YVjQK0sZ1LgFeAfJMO9RjqFkTD7uqEdPiZGXvBCJcse cMx716BRJ5IUV8sadotGhK+VSdLoV+CdtymqL3GDPKBOV5mG4QfEI+7DgrEF7qwJKE1y KlhQ== X-Gm-Message-State: AOAM531PX7qGR6foX+Isa0wOmpSdQ5lASK5WeeArnmJKm82c64pK5wK4 tyXBwMyT0afpLA0VoYOmvjM= X-Google-Smtp-Source: ABdhPJzFf31qSZEB+rz+YEP3aKkRbpO/EEZTy9LJtkbAfWnFusqjfiDRkoyYFpW0BVjvl2s7awSbUA== X-Received: by 2002:a37:543:: with SMTP id 64mr10718958qkf.170.1599790440118; Thu, 10 Sep 2020 19:14:00 -0700 (PDT) Received: from ubuntu-n2-xlarge-x86 ([2604:1380:45d1:2600::1]) by smtp.gmail.com with ESMTPSA id q68sm1111689qkd.45.2020.09.10.19.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 19:13:59 -0700 (PDT) Date: Thu, 10 Sep 2020 19:13:58 -0700 From: Nathan Chancellor To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, Anshuman Khandual Subject: Re: [PATCH v4 13/13] mm/debug_vm_pgtable: Avoid none pte in pte_clear_test Message-ID: <20200911021358.GA3656343@ubuntu-n2-xlarge-x86> References: <20200902114222.181353-1-aneesh.kumar@linux.ibm.com> <20200902114222.181353-14-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902114222.181353-14-aneesh.kumar@linux.ibm.com> X-Rspamd-Queue-Id: 755F618229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 02, 2020 at 05:12:22PM +0530, Aneesh Kumar K.V wrote: > pte_clear_tests operate on an existing pte entry. Make sure that > is not a none pte entry. > > Signed-off-by: Aneesh Kumar K.V > --- > mm/debug_vm_pgtable.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 9afa1354326b..c36530c69e33 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -542,9 +542,10 @@ static void __init pgd_populate_tests(struct mm_struct *mm, pgd_t *pgdp, > #endif /* PAGETABLE_P4D_FOLDED */ > > static void __init pte_clear_tests(struct mm_struct *mm, pte_t *ptep, > - unsigned long vaddr) > + unsigned long pfn, unsigned long vaddr, > + pgprot_t prot) > { > - pte_t pte = ptep_get(ptep); > + pte_t pte = pfn_pte(pfn, prot); > > pr_debug("Validating PTE clear\n"); > pte = __pte(pte_val(pte) | RANDOM_ORVALUE); > @@ -1049,7 +1050,7 @@ static int __init debug_vm_pgtable(void) > > ptl = pte_lockptr(mm, pmdp); > spin_lock(ptl); > - pte_clear_tests(mm, ptep, vaddr); > + pte_clear_tests(mm, ptep, pte_aligned, vaddr, prot); > pte_advanced_tests(mm, vma, ptep, pte_aligned, vaddr, prot); > pte_unmap_unlock(ptep, ptl); > > -- > 2.26.2 > > This patch causes a panic at boot for RISC-V defconfig. The rootfs is here if it is needed: https://github.com/ClangBuiltLinux/boot-utils/blob/3b21a5b71451742866349ba4f18638c5a754e660/images/riscv/rootfs.cpio.zst $ make -skj"$(nproc)" ARCH=riscv CROSS_COMPILE=riscv64-linux- O=out/riscv distclean defconfig Image $ qemu-system-riscv64 -bios default -M virt -display none -initrd rootfs.cpio -kernel Image -m 512m -nodefaults -serial mon:stdio ... OpenSBI v0.6 ____ _____ ____ _____ / __ \ / ____| _ \_ _| | | | |_ __ ___ _ __ | (___ | |_) || | | | | | '_ \ / _ \ '_ \ \___ \| _ < | | | |__| | |_) | __/ | | |____) | |_) || |_ \____/| .__/ \___|_| |_|_____/|____/_____| | | |_| Platform Name : QEMU Virt Machine Platform HART Features : RV64ACDFIMSU Platform Max HARTs : 8 Current Hart : 0 Firmware Base : 0x80000000 Firmware Size : 120 KB Runtime SBI Version : 0.2 MIDELEG : 0x0000000000000222 MEDELEG : 0x000000000000b109 PMP0 : 0x0000000080000000-0x000000008001ffff (A) PMP1 : 0x0000000000000000-0xffffffffffffffff (A,R,W,X) [ 0.000000] Linux version 5.9.0-rc4-next-20200910 (nathan@ubuntu-n2-xlarge-x86) (riscv64-linux-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.35) #1 SMP Thu Sep 10 19:10:43 MST 2020 ... [ 0.294593] NET: Registered protocol family 17 [ 0.295781] 9pnet: Installing 9P2000 support [ 0.296153] Key type dns_resolver registered [ 0.296694] debug_vm_pgtable: [debug_vm_pgtable ]: Validating architecture page table helpers [ 0.297635] Unable to handle kernel paging request at virtual address 0a7fffe01dafefc8 [ 0.298029] Oops [#1] [ 0.298153] Modules linked in: [ 0.298433] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.9.0-rc4-next-20200910 #1 [ 0.298792] epc: ffffffe000205afc ra : ffffffe0008be0aa sp : ffffffe01ae73d40 [ 0.299078] gp : ffffffe0010b9b48 tp : ffffffe01ae68000 t0 : ffffffe008152000 [ 0.299362] t1 : 0000000000000000 t2 : 0000000000000000 s0 : ffffffe01ae73d60 [ 0.299648] s1 : bffffffffffffffb a0 : 0a7fffe01dafefc8 a1 : bffffffffffffffb [ 0.299948] a2 : ffffffe0010a2698 a3 : 0000000000000001 a4 : 0000000000000003 [ 0.300231] a5 : 0000000000000800 a6 : fffffffff0000080 a7 : 000000001b642000 [ 0.300521] s2 : ffffffe0081517b8 s3 : ffffffe008150a80 s4 : ffffffe01af30000 [ 0.300806] s5 : ffffffe01f8ca9b8 s6 : ffffffe008150000 s7 : ffffffe0010bb100 [ 0.301161] s8 : ffffffe0010bb108 s9 : 0000000000080202 s10: ffffffe0010bb928 [ 0.301481] s11: 000000002008085b t3 : 0000000000000000 t4 : 0000000000000000 [ 0.301722] t5 : 0000000000000000 t6 : ffffffe008150000 [ 0.301947] status: 0000000000000120 badaddr: 0a7fffe01dafefc8 cause: 000000000000000f [ 0.302569] ---[ end trace 7ffb153d816164cf ]--- [ 0.302797] note: swapper/0[1] exited with preempt_count 1 [ 0.303101] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 0.303614] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- $ git bisect log # bad: [7ce53e3a447bced7b85ed181c4d027e93c062e07] Add linux-next specific files for 20200910 # good: [34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8] Merge tag 'linux-kselftest-5.9-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest git bisect start '7ce53e3a447bced7b85ed181c4d027e93c062e07' '34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8' # good: [bb1f09d126618aa1ec776d87d7f85136edbed485] Merge remote-tracking branch 'crypto/master' into master git bisect good bb1f09d126618aa1ec776d87d7f85136edbed485 # good: [1fb7e980a0f9a0aa4c7daba1a7e35d12c97820ea] Merge remote-tracking branch 'audit/next' into master git bisect good 1fb7e980a0f9a0aa4c7daba1a7e35d12c97820ea # good: [afdf05baff78a658843c1013855985e7a6871406] Merge remote-tracking branch 'thunderbolt/next' into master git bisect good afdf05baff78a658843c1013855985e7a6871406 # good: [c5f3c031bd4b8ef5fb6b07352abc284603c3edee] Merge remote-tracking branch 'kselftest/next' into master git bisect good c5f3c031bd4b8ef5fb6b07352abc284603c3edee # bad: [671aca25e253f2773850aefb0837a225c691e336] lib: bitmap: delete duplicated words git bisect bad 671aca25e253f2773850aefb0837a225c691e336 # bad: [e42ac710a849403b7fe582cc555dc3b7bf5b6fa9] tools/testing/selftests/vm/hmm-tests.c: use the new SKIP() macro git bisect bad e42ac710a849403b7fe582cc555dc3b7bf5b6fa9 # good: [1443e3384317a9dfaf1381e8134a69c1e3fc7130] device-dax: kill dax_kmem_res git bisect good 1443e3384317a9dfaf1381e8134a69c1e3fc7130 # good: [e2aad6f1d232b457ea6a3194992dd4c0a83534a5] mm/debug_vm_pgtable/locks: take correct page table lock git bisect good e2aad6f1d232b457ea6a3194992dd4c0a83534a5 # bad: [08075d21b791241ba9f1366f814afa4a77372250] mm: workingset: ignore slab memory size when calculating shadows pressure git bisect bad 08075d21b791241ba9f1366f814afa4a77372250 # bad: [42e9e63856020953cc3645a2032a70179364a1d8] mm-gup-dont-permit-users-to-call-get_user_pages-with-foll_longterm-fix git bisect bad 42e9e63856020953cc3645a2032a70179364a1d8 # good: [b77bfa2ce4c2e30c1b1d1b3eb18c5b57397277f9] mm/debug_vm_pgtable/hugetlb: disable hugetlb test on ppc64 git bisect good b77bfa2ce4c2e30c1b1d1b3eb18c5b57397277f9 # bad: [90b612d56df39666f0f6fa6a033b4a7ec2e0a16c] mm/gup_benchmark: use pin_user_pages for FOLL_LONGTERM flag git bisect bad 90b612d56df39666f0f6fa6a033b4a7ec2e0a16c # bad: [060e70ecf865e55d82282995b4cb478126a1163c] mm/debug_vm_pgtable: avoid none pte in pte_clear_test git bisect bad 060e70ecf865e55d82282995b4cb478126a1163c # first bad commit: [060e70ecf865e55d82282995b4cb478126a1163c] mm/debug_vm_pgtable: avoid none pte in pte_clear_test Cheers, Nathan