From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E900C43461 for ; Mon, 14 Sep 2020 13:26:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28A3B206B8 for ; Mon, 14 Sep 2020 13:26:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UcmAqdO0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28A3B206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C050F900004; Mon, 14 Sep 2020 09:26:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8CA4900002; Mon, 14 Sep 2020 09:26:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2E65900004; Mon, 14 Sep 2020 09:26:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 88DDA900002 for ; Mon, 14 Sep 2020 09:26:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 400DD18015CA8 for ; Mon, 14 Sep 2020 13:26:31 +0000 (UTC) X-FDA: 77261741382.05.boot88_4607bb827108 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 066671837F9FA for ; Mon, 14 Sep 2020 13:26:31 +0000 (UTC) X-HE-Tag: boot88_4607bb827108 X-Filterd-Recvd-Size: 4176 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 13:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=uGAwZnkn87pwanHSJb4fYgmseaVLFFvMj2rf/LwreS0=; b=UcmAqdO0gGOB8BAVcvtqwyeVtE tweSp8hSMUS03RaY23JdxfwMtjP3Y1v2aKCHTJQfBmtTxzhx03T7xWLfCsHzEwYUKt0BEsQm1xKxX xjS4VdmLU40hgQ6yexi2ShxOBHnpuGgnYm4jmtFfyoCOCQnVdRhuZW0hIM4XA5akCLnGhh/06kAHe 5t6oxvDtat206x23o9C8dyOw65/zGEFtmnEJGO+jzveHuyVSQ+24U/yU4vTw+0mH7dq4mda+72MqO DFcj6MmpAW35JLZzmej+U1fQKo/XEOCHb00LSe3pAqLZKf0dZadN55Y6x2ceay9n6igGSLJQFB++Q EYTVaxNw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHo6A-00030I-56; Mon, 14 Sep 2020 13:00:46 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , Hugh Dickins , William Kucharski , Johannes Weiner , Jan Kara , Yang Shi , Dave Chinner , linux-kernel@vger.kernel.org Subject: [PATCH v2 08/12] mm: Remove nr_entries parameter from pagevec_lookup_entries Date: Mon, 14 Sep 2020 14:00:38 +0100 Message-Id: <20200914130042.11442-9-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200914130042.11442-1-willy@infradead.org> References: <20200914130042.11442-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 066671837F9FA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All callers want to fetch the full size of the pvec. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 2 +- mm/swap.c | 4 ++-- mm/truncate.c | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index 4b245592262c..ce77724a2ab7 100644 --- a/include/linux/pagevec.h +++ b/include/linux/pagevec.h @@ -27,7 +27,7 @@ void __pagevec_release(struct pagevec *pvec); void __pagevec_lru_add(struct pagevec *pvec); unsigned pagevec_lookup_entries(struct pagevec *pvec, struct address_space *mapping, pgoff_t start, pgoff_t end, - unsigned nr_entries, pgoff_t *indices); + pgoff_t *indices); void pagevec_remove_exceptionals(struct pagevec *pvec); unsigned pagevec_lookup_range(struct pagevec *pvec, struct address_space *mapping, diff --git a/mm/swap.c b/mm/swap.c index b6e56a84b466..d4e3ba4c967c 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -1058,9 +1058,9 @@ void __pagevec_lru_add(struct pagevec *pvec) */ unsigned pagevec_lookup_entries(struct pagevec *pvec, struct address_space *mapping, pgoff_t start, pgoff_t end, - unsigned nr_entries, pgoff_t *indices) + pgoff_t *indices) { - pvec->nr =3D find_get_entries(mapping, start, end, nr_entries, + pvec->nr =3D find_get_entries(mapping, start, end, PAGEVEC_SIZE, pvec->pages, indices); return pagevec_count(pvec); } diff --git a/mm/truncate.c b/mm/truncate.c index 69ea72e7fc1c..bbd0a02eaed7 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -377,7 +377,7 @@ void truncate_inode_pages_range(struct address_space = *mapping, for ( ; ; ) { cond_resched(); if (!pagevec_lookup_entries(&pvec, mapping, index, end - 1, - PAGEVEC_SIZE, indices)) { + indices)) { /* If all gone from start onwards, we're done */ if (index =3D=3D start) break; @@ -611,8 +611,7 @@ int invalidate_inode_pages2_range(struct address_spac= e *mapping, =20 pagevec_init(&pvec); index =3D start; - while (pagevec_lookup_entries(&pvec, mapping, index, end, - PAGEVEC_SIZE, indices)) { + while (pagevec_lookup_entries(&pvec, mapping, index, end, indices)) { for (i =3D 0; i < pagevec_count(&pvec); i++) { struct page *page =3D pvec.pages[i]; =20 --=20 2.28.0