From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC571C433E2 for ; Tue, 15 Sep 2020 12:52:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDE2620756 for ; Tue, 15 Sep 2020 12:52:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HKTzzEbk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDE2620756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00DF36B009A; Tue, 15 Sep 2020 08:52:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F036F90001D; Tue, 15 Sep 2020 08:52:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15B76B009D; Tue, 15 Sep 2020 08:52:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id CBE546B009A for ; Tue, 15 Sep 2020 08:52:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7C813181AC553 for ; Tue, 15 Sep 2020 12:52:20 +0000 (UTC) X-FDA: 77265284040.26.drug66_1d1298127111 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 551881804B65A for ; Tue, 15 Sep 2020 12:52:20 +0000 (UTC) X-HE-Tag: drug66_1d1298127111 X-Filterd-Recvd-Size: 2427 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 12:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UCxmPzGmRfbpQrKGfHH5RY5PgxbdZoTXfnyb0A0S5Ag=; b=HKTzzEbkebCqYm+ofegFWTBAHK FLp0GaoofkFzOzO9NKxkMaPO8jtLwxVz46y3T0Su+1qymDtzwI7EDCtNToQDC+r9E7zMc/D8SLPkl 9NcVY3Yw79uC/473dXLjasCATO/b0lNS+ZGU3ozS7fdGK0Ji2HOEDpdAGxAAeENmmUcuxy0+6iy8h FegHZzP0pAndRBtyleT8X2CrHaApazjl+ulXNOjDn1obyjq8rxPrE+aMiIKo8QwZ25qTmGY4r6ZyJ s92VJl/s2Y32u4Gw7TSjjlGuFsFXiFawHqhy1zcfhUnxrXRdVuMer3I37KdonlJ7ohCspPLLM/+LZ xAImuOQA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIARR-0008E5-97; Tue, 15 Sep 2020 12:52:13 +0000 Date: Tue, 15 Sep 2020 13:52:13 +0100 From: Matthew Wilcox To: SeongJae Park Cc: linux-mm@kvack.org, Andrew Morton , "Kirill A . Shutemov" , Huang Ying Subject: Re: [PATCH 11/11] mm/vmscan: Allow arbitrary sized pages to be paged out Message-ID: <20200915125213.GB5449@casper.infradead.org> References: <20200908195539.25896-12-willy@infradead.org> <20200915074045.17570-1-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915074045.17570-1-sjpark@amazon.com> X-Rspamd-Queue-Id: 551881804B65A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 09:40:45AM +0200, SeongJae Park wrote: > On Tue, 8 Sep 2020 20:55:38 +0100 "Matthew Wilcox (Oracle)" wrote: > > Remove the assumption that a compound page has HPAGE_PMD_NR pins from > > the page cache. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Cc: Huang Ying > > - int page_cache_pins = PageTransHuge(page) && PageSwapCache(page) ? > > - HPAGE_PMD_NR : 1; > > + int page_cache_pins = thp_nr_pages(page); > > Is it ok to remove the PageSwapCache() check? I think so? My understanding is that it was added in commit bd4c82c22c36 to catch shmem pages, but there was really no reason to only do this for shmem pages.