From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79006C2D0E3 for ; Thu, 17 Sep 2020 17:10:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF29C206CA for ; Thu, 17 Sep 2020 17:10:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="X6yFktcv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF29C206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 40A0A8E0001; Thu, 17 Sep 2020 13:10:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 393DC6B0082; Thu, 17 Sep 2020 13:10:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25AB68E0001; Thu, 17 Sep 2020 13:10:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 08B046B0080 for ; Thu, 17 Sep 2020 13:10:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C3E02180AD830 for ; Thu, 17 Sep 2020 17:10:42 +0000 (UTC) X-FDA: 77273192724.28.crown08_350f05b27124 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 8450C6C11 for ; Thu, 17 Sep 2020 17:10:42 +0000 (UTC) X-HE-Tag: crown08_350f05b27124 X-Filterd-Recvd-Size: 4951 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 17:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=mK3IFrmKleYuDfPBu63jJazzBdauHkYdgkU6Y/JSZC8=; b=X6yFktcvg5hw7cyC0dZfNIdN/Z GDJEti+OILxMrNcBRjnmpoB0cgxZwsisX+gZjKVzxA2UUGOmGkItf4rFAbk91SB3zI3mytK0ijef9 FdXWLarqrOn4DvMwEySPQvY7EIoBWJHTd5gwEUC7Ze11XeyFCQQmWDHqXlEfAjaDawuDC/i6lNIZ2 kd5MpEmVfkNsRz3bpgEmrfuivqbfu1ugD0F1EpxdbeEuM8rz7mNMkqWIT5vp3TcO44MXTkr3yYRMN c9eb3cAqbq8uv1SANeDpuOmr3ITZql1w/I2TwuEB4oX9MQUt2fKBBv4vbESO6v6FXz2ZIvWRUyGTG yYANbuyA==; Received: from 089144214092.atnat0023.highway.a1.net ([89.144.214.92] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIxQS-0001AF-5b; Thu, 17 Sep 2020 17:10:28 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-ide@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: [PATCH 05/14] pktcdvd: use blkdev_get_by_dev instead of open coding it Date: Thu, 17 Sep 2020 18:57:11 +0200 Message-Id: <20200917165720.3285256-6-hch@lst.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200917165720.3285256-1-hch@lst.de> References: <20200917165720.3285256-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Replace bdget + blkdev_get by blkdev_get_by_dev. Signed-off-by: Christoph Hellwig --- drivers/block/pktcdvd.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index bc870a5f15f77b..467dbd06b7cdb1 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2110,16 +2110,18 @@ static int pkt_open_dev(struct pktcdvd_device *pd= , fmode_t write) int ret; long lba; struct request_queue *q; + struct block_device *bdev; =20 /* * We need to re-open the cdrom device without O_NONBLOCK to be able * to read/write from/to it. It is already opened in O_NONBLOCK mode - * so bdget() can't fail. + * so open should not fail. */ - bdget(pd->bdev->bd_dev); - ret =3D blkdev_get(pd->bdev, FMODE_READ | FMODE_EXCL, pd); - if (ret) + bdev =3D blkdev_get_by_dev(pd->bdev->bd_dev, FMODE_READ | FMODE_EXCL, p= d); + if (IS_ERR(bdev)) { + ret =3D PTR_ERR(bdev); goto out; + } =20 ret =3D pkt_get_last_written(pd, &lba); if (ret) { @@ -2163,7 +2165,7 @@ static int pkt_open_dev(struct pktcdvd_device *pd, = fmode_t write) return 0; =20 out_putdev: - blkdev_put(pd->bdev, FMODE_READ | FMODE_EXCL); + blkdev_put(bdev, FMODE_READ | FMODE_EXCL); out: return ret; } @@ -2500,7 +2502,6 @@ static int pkt_seq_show(struct seq_file *m, void *p= ) static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev) { int i; - int ret =3D 0; char b[BDEVNAME_SIZE]; struct block_device *bdev; =20 @@ -2523,12 +2524,9 @@ static int pkt_new_dev(struct pktcdvd_device *pd, = dev_t dev) } } =20 - bdev =3D bdget(dev); - if (!bdev) - return -ENOMEM; - ret =3D blkdev_get(bdev, FMODE_READ | FMODE_NDELAY, NULL); - if (ret) - return ret; + bdev =3D blkdev_get_by_dev(dev, FMODE_READ | FMODE_NDELAY, NULL); + if (IS_ERR(bdev)) + return PTR_ERR(bdev); if (!blk_queue_scsi_passthrough(bdev_get_queue(bdev))) { blkdev_put(bdev, FMODE_READ | FMODE_NDELAY); return -EINVAL; @@ -2546,7 +2544,6 @@ static int pkt_new_dev(struct pktcdvd_device *pd, d= ev_t dev) pd->cdrw.thread =3D kthread_run(kcdrwd, pd, "%s", pd->name); if (IS_ERR(pd->cdrw.thread)) { pkt_err(pd, "can't start kernel thread\n"); - ret =3D -ENOMEM; goto out_mem; } =20 @@ -2558,7 +2555,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, d= ev_t dev) blkdev_put(bdev, FMODE_READ | FMODE_NDELAY); /* This is safe: open() is still holding a reference. */ module_put(THIS_MODULE); - return ret; + return -ENOMEM; } =20 static int pkt_ioctl(struct block_device *bdev, fmode_t mode, unsigned i= nt cmd, unsigned long arg) --=20 2.28.0